From 9227fa428d9927aacdfe9125357d0380e2f727fc Mon Sep 17 00:00:00 2001
From: Jack Foltz <jack@foltz.io>
Date: Sat, 28 Jul 2018 12:53:49 -0400
Subject: [PATCH] Add checks for bad requests in auth.js to prevent 500

---
 app/routes/auth.js | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/app/routes/auth.js b/app/routes/auth.js
index ebeaaed..30be9af 100644
--- a/app/routes/auth.js
+++ b/app/routes/auth.js
@@ -63,6 +63,15 @@ async function validateInvite(code) {
 
 
 router.post('/register', canonicalizeRequest, wrap(async (req, res) => {
+    if (!req.body.displayname)
+        return res.status(400).json({message: 'No displayname specified.'});
+
+    if (!req.body.password)
+        return res.status(400).json({message: 'No password specified.'});
+
+    if (!req.body.invite)
+        return res.status(400).json({message: 'No invite specified.'});
+
     // Validate the invite and username
     const [inviteStatus, usernameStatus] =
         await Promise.all([
@@ -91,6 +100,12 @@ router.post('/register', canonicalizeRequest, wrap(async (req, res) => {
 }));
 
 router.post('/login', canonicalizeRequest, wrap(async (req, res, next) => {
+    if (!req.body.username)
+        return res.status(400).json({message: 'No username specified.'});
+
+    if (!req.body.password)
+        return res.status(400).json({message: 'No password specified.'});
+
     // Authenticate
     const user = await authenticate(req, res, next);
     if (!user)
@@ -107,6 +122,9 @@ router.post('/login', canonicalizeRequest, wrap(async (req, res, next) => {
 }));
 
 router.post('/logout', function (req, res) {
+    if (!req.isAuthenticated())
+        return res.status(400).json({message: 'Not logged in.'});
+
     req.logout();
     res.status(200).json({'message': 'Logged out.'});
 });