foltik/shimapan
1
0
Fork 0
mirror of https://github.com/Foltik/Shimapan synced 2024-12-03 10:59:13 -05:00
Code Issues Releases Wiki Activity

Fix username in use check and whitespace sanitization

Browse Source
This commit is contained in:
Jack Foltz 2018-07-24 19:37:49 -04:00
parent 150b736071
commit c0f924bb59
Signed by: foltik
GPG Key ID: 303F88F996E95541
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
app/routes/auth.js
View File

@ -31,20 +31,33 @@ function checkInvite(code, cb) {
} }
// Validates the username, then registers the user in the database using the given invite. // Validates the username, then registers the user in the database using the given invite.
function registerUser(username, password, invite, sanitizeFn, cb) { function registerUser(username, password, invite, sanitize, cb) {
async.series([ async.series([
function (cb) { function (cb) {
// Canonicalize and sanitize the username, checking for HTML // Canonicalize and sanitize the username, checking for HTML
var canonicalName = canonicalize(username); var canonicalName = canonicalize(username);
var sanitizedName = sanitizeFn(canonicalName); var sanitizedName = sanitize(canonicalName).replace(/\s/g,'');
if (sanitizedName !== canonicalName) if (sanitizedName !== canonicalName)
cb('Username failed sanitization check.'); cb('Username contains invalid characters.');
else if (canonicalName.length > 36) else if (canonicalName.length > 36)
cb('Username too long.'); cb('Username too long.');
else else
cb(null); cb(null);
}, },
function(cb) {
async.waterfall([
function(cb) {
User.count({canonicalname: canonicalize(username)}, cb);
},
function(count, cb) {
if (count !== 0)
cb('Username in use.');
else
cb(null);
}
], cb);
},
function (cb) { function (cb) {
User.register(new User({ User.register(new User({
username: username, username: username,