More ban stuff: Show whether or not user has "seen" a ban yet in the ban list and on IP address pages. Purge useless expired ban records.

inc/functions.php

@@ -654,6 +654,16 @@ function checkBan($board = 0) {
 		
 		displayBan($ban);
 	}
+	
+	// I'm not sure where else to put this. It doesn't really matter where; it just needs to be called every now and then to keep the ban list tidy.
+	purge_bans();
+}
+
+// No reason to keep expired bans in the database (except those that haven't been viewed yet)
+function purge_bans() {
+	$query = prepare("DELETE FROM `bans` WHERE `expires` IS NOT NULL AND `expires` < :time AND `seen` = 1");
+	$query->bindValue(':time', time());
+	$query->execute() or error(db_error($query));
 }
 
 function threadLocked($id) {

templates/mod/ban_list.html

@@ -10,6 +10,7 @@
 				<th>{% trans 'Set' %}</th>
 				<th>{% trans 'Duration' %}</th>
 				<th>{% trans 'Expires' %}</th>
+				<th>{% trans 'Seen' %}</th>
 				<th>{% trans 'Staff' %}</th>
 			</tr>
 			{% for ban in bans %}
@@ -59,6 +60,13 @@
 						{% endif %}
 					</td>
 					<td>
+						{%  if ban.seen %}
+							{% trans 'Yes' %}
+						{%  else %}
+							{% trans 'No' %}
+						{%  endif %}
+					</td>
+					<td>
 						{% if ban.username %}
 							{% if mod|hasPermission(config.mod.view_banstaff) %}
 								<a href="?/new_PM/{{ ban.username|e }}">{{ ban.username|e }}</a>

templates/mod/view_ip.html

@@ -137,6 +137,16 @@
 						</td>
 					</tr>
 					<tr>
+						<th>{% trans 'Seen' %}</th>
+						<td>
+							{%  if ban.seen %}
+								{% trans 'Yes' %}
+							{%  else %}
+								{% trans 'No' %}
+							{%  endif %}
+						</td>
+					</tr>
+					<tr>
 						<th>{% trans 'Staff' %}</th>
 						<td>
 							{% if ban.username %}