use NULL in database where possible

This commit is contained in:
Savetheinternet 2011-12-05 10:47:30 +11:00
parent c5a961a6a5
commit fc417bc446
3 changed files with 24 additions and 9 deletions

View File

@ -567,10 +567,25 @@
$query = prepare(sprintf("INSERT INTO `posts_%s` VALUES ( NULL, :thread, :subject, :email, :name, :trip, :capcode, :body, :time, :time, :thumb, :thumbwidth, :thumbheight, :file, :width, :height, :filesize, :filename, :filehash, :password, :ip, :sticky, :locked, 0, :embed)", $board['uri']));
// Basic stuff
if(!empty($post['subject'])) {
$query->bindValue(':subject', $post['subject']);
} else {
$query->bindValue(':subject', NULL, PDO::PARAM_NULL);
}
if(!empty($post['email'])) {
$query->bindValue(':email', $post['email']);
$query->bindValue(':name', $post['name']);
} else {
$query->bindValue(':email', NULL, PDO::PARAM_NULL);
}
if(!empty($post['trip'])) {
$query->bindValue(':trip', $post['trip']);
} else {
$query->bindValue(':trip', NULL, PDO::PARAM_NULL);
}
$query->bindValue(':name', $post['name']);
$query->bindValue(':body', $post['body']);
$query->bindValue(':time', isset($post['time']) ? $post['time'] : time(), PDO::PARAM_INT);
$query->bindValue(':password', $post['password']);

View File

@ -182,9 +182,9 @@ CREATE TABLE IF NOT EXISTS `pms` (
CREATE TABLE IF NOT EXISTS `posts_b` (
`id` int(11) NOT NULL AUTO_INCREMENT,
`thread` int(11) DEFAULT NULL,
`subject` varchar(100) NOT NULL,
`email` varchar(30) NOT NULL,
`name` varchar(35) NOT NULL,
`subject` varchar(100) DEFAULT NULL,
`email` varchar(30) DEFAULT NULL,
`name` varchar(35) DEFAULT NULL,
`trip` varchar(15) DEFAULT NULL,
`capcode` varchar(50) DEFAULT NULL,
`body` text NOT NULL,

View File

@ -1,9 +1,9 @@
CREATE TABLE IF NOT EXISTS `posts_{{ board }}` (
`id` int(11) NOT NULL AUTO_INCREMENT,
`thread` int(11) DEFAULT NULL,
`subject` varchar(100) NOT NULL,
`email` varchar(30) NOT NULL,
`name` varchar(35) NOT NULL,
`subject` varchar(100) DEFAULT NULL,
`email` varchar(30) DEFAULT NULL,
`name` varchar(35) DEFAULT NULL,
`trip` varchar(15) DEFAULT NULL,
`capcode` varchar(50) DEFAULT NULL,
`body` text NOT NULL,