2018-12-23 15:11:29 -05:00
|
|
|
# Pleroma: A lightweight social networking server
|
|
|
|
# Copyright © 2017-2018 Pleroma Authors <https://pleroma.social/>
|
|
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
|
2018-11-20 11:46:54 -05:00
|
|
|
defmodule Pleroma.MediaProxyTest do
|
|
|
|
use ExUnit.Case
|
|
|
|
import Pleroma.Web.MediaProxy
|
2018-12-07 15:44:04 -05:00
|
|
|
alias Pleroma.Web.MediaProxy.MediaProxyController
|
2018-11-20 11:46:54 -05:00
|
|
|
|
2019-05-01 09:28:04 -04:00
|
|
|
setup do
|
|
|
|
enabled = Pleroma.Config.get([:media_proxy, :enabled])
|
|
|
|
on_exit(fn -> Pleroma.Config.put([:media_proxy, :enabled], enabled) end)
|
|
|
|
:ok
|
|
|
|
end
|
|
|
|
|
2018-11-20 11:46:54 -05:00
|
|
|
describe "when enabled" do
|
|
|
|
setup do
|
2019-05-01 09:28:04 -04:00
|
|
|
Pleroma.Config.put([:media_proxy, :enabled], true)
|
2018-11-20 11:46:54 -05:00
|
|
|
:ok
|
|
|
|
end
|
|
|
|
|
|
|
|
test "ignores invalid url" do
|
|
|
|
assert url(nil) == nil
|
|
|
|
assert url("") == nil
|
|
|
|
end
|
|
|
|
|
|
|
|
test "ignores relative url" do
|
|
|
|
assert url("/local") == "/local"
|
|
|
|
assert url("/") == "/"
|
|
|
|
end
|
|
|
|
|
|
|
|
test "ignores local url" do
|
|
|
|
local_url = Pleroma.Web.Endpoint.url() <> "/hello"
|
|
|
|
local_root = Pleroma.Web.Endpoint.url()
|
|
|
|
assert url(local_url) == local_url
|
|
|
|
assert url(local_root) == local_root
|
|
|
|
end
|
|
|
|
|
|
|
|
test "encodes and decodes URL" do
|
|
|
|
url = "https://pleroma.soykaf.com/static/logo.png"
|
|
|
|
encoded = url(url)
|
|
|
|
|
|
|
|
assert String.starts_with?(
|
|
|
|
encoded,
|
|
|
|
Pleroma.Config.get([:media_proxy, :base_url], Pleroma.Web.base_url())
|
|
|
|
)
|
|
|
|
|
|
|
|
assert String.ends_with?(encoded, "/logo.png")
|
|
|
|
|
|
|
|
assert decode_result(encoded) == url
|
|
|
|
end
|
|
|
|
|
|
|
|
test "encodes and decodes URL without a path" do
|
|
|
|
url = "https://pleroma.soykaf.com"
|
|
|
|
encoded = url(url)
|
|
|
|
assert decode_result(encoded) == url
|
|
|
|
end
|
|
|
|
|
|
|
|
test "encodes and decodes URL without an extension" do
|
|
|
|
url = "https://pleroma.soykaf.com/path/"
|
|
|
|
encoded = url(url)
|
|
|
|
assert String.ends_with?(encoded, "/path")
|
|
|
|
assert decode_result(encoded) == url
|
|
|
|
end
|
|
|
|
|
|
|
|
test "encodes and decodes URL and ignores query params for the path" do
|
|
|
|
url = "https://pleroma.soykaf.com/static/logo.png?93939393939&bunny=true"
|
|
|
|
encoded = url(url)
|
|
|
|
assert String.ends_with?(encoded, "/logo.png")
|
|
|
|
assert decode_result(encoded) == url
|
|
|
|
end
|
|
|
|
|
2018-12-07 15:44:04 -05:00
|
|
|
test "ensures urls are url-encoded" do
|
|
|
|
assert decode_result(url("https://pleroma.social/Hello world.jpg")) ==
|
|
|
|
"https://pleroma.social/Hello%20world.jpg"
|
|
|
|
|
|
|
|
assert decode_result(url("https://pleroma.social/Hello%20world.jpg")) ==
|
|
|
|
"https://pleroma.social/Hello%20world.jpg"
|
|
|
|
end
|
|
|
|
|
2018-11-20 11:46:54 -05:00
|
|
|
test "validates signature" do
|
|
|
|
secret_key_base = Pleroma.Config.get([Pleroma.Web.Endpoint, :secret_key_base])
|
|
|
|
|
|
|
|
on_exit(fn ->
|
|
|
|
Pleroma.Config.put([Pleroma.Web.Endpoint, :secret_key_base], secret_key_base)
|
|
|
|
end)
|
|
|
|
|
|
|
|
encoded = url("https://pleroma.social")
|
|
|
|
|
|
|
|
Pleroma.Config.put(
|
|
|
|
[Pleroma.Web.Endpoint, :secret_key_base],
|
|
|
|
"00000000000000000000000000000000000000000000000"
|
|
|
|
)
|
|
|
|
|
|
|
|
[_, "proxy", sig, base64 | _] = URI.parse(encoded).path |> String.split("/")
|
|
|
|
assert decode_url(sig, base64) == {:error, :invalid_signature}
|
|
|
|
end
|
2018-11-30 11:44:12 -05:00
|
|
|
|
2019-07-12 11:17:55 -04:00
|
|
|
test "filename_matches preserves the encoded or decoded path" do
|
2018-12-07 15:44:04 -05:00
|
|
|
assert MediaProxyController.filename_matches(
|
|
|
|
true,
|
2019-07-12 11:17:55 -04:00
|
|
|
"/Hello world.jpg",
|
2018-12-07 15:44:04 -05:00
|
|
|
"http://pleroma.social/Hello world.jpg"
|
|
|
|
) == :ok
|
|
|
|
|
|
|
|
assert MediaProxyController.filename_matches(
|
|
|
|
true,
|
|
|
|
"/Hello%20world.jpg",
|
|
|
|
"http://pleroma.social/Hello%20world.jpg"
|
|
|
|
) == :ok
|
|
|
|
|
|
|
|
assert MediaProxyController.filename_matches(
|
|
|
|
true,
|
2019-07-12 11:17:55 -04:00
|
|
|
"/my%2Flong%2Furl%2F2019%2F07%2FS.jpg",
|
|
|
|
"http://pleroma.social/my%2Flong%2Furl%2F2019%2F07%2FS.jpg"
|
2018-12-07 15:44:04 -05:00
|
|
|
) == :ok
|
|
|
|
end
|
|
|
|
|
2019-07-12 12:34:30 -04:00
|
|
|
test "encoded url are tried to match for proxy as `conn.request_path` encodes the url" do
|
|
|
|
# conn.request_path will return encoded url
|
|
|
|
request_path = "/ANALYSE-DAI-_-LE-STABLECOIN-100-D%C3%89CENTRALIS%C3%89-BQ.jpg"
|
|
|
|
|
|
|
|
assert MediaProxyController.filename_matches(
|
|
|
|
true,
|
|
|
|
request_path,
|
|
|
|
"https://mydomain.com/uploads/2019/07/ANALYSE-DAI-_-LE-STABLECOIN-100-DÉCENTRALISÉ-BQ.jpg"
|
|
|
|
) == :ok
|
|
|
|
end
|
|
|
|
|
2018-11-30 11:44:12 -05:00
|
|
|
test "uses the configured base_url" do
|
|
|
|
base_url = Pleroma.Config.get([:media_proxy, :base_url])
|
|
|
|
|
|
|
|
if base_url do
|
|
|
|
on_exit(fn ->
|
|
|
|
Pleroma.Config.put([:media_proxy, :base_url], base_url)
|
|
|
|
end)
|
|
|
|
end
|
|
|
|
|
|
|
|
Pleroma.Config.put([:media_proxy, :base_url], "https://cache.pleroma.social")
|
|
|
|
|
|
|
|
url = "https://pleroma.soykaf.com/static/logo.png"
|
|
|
|
encoded = url(url)
|
|
|
|
|
|
|
|
assert String.starts_with?(encoded, Pleroma.Config.get([:media_proxy, :base_url]))
|
|
|
|
end
|
2019-02-14 03:55:21 -05:00
|
|
|
|
|
|
|
# https://git.pleroma.social/pleroma/pleroma/issues/580
|
|
|
|
test "encoding S3 links (must preserve `%2F`)" do
|
|
|
|
url =
|
|
|
|
"https://s3.amazonaws.com/example/test.png?X-Amz-Credential=your-access-key-id%2F20130721%2Fus-east-1%2Fs3%2Faws4_request"
|
|
|
|
|
|
|
|
encoded = url(url)
|
|
|
|
assert decode_result(encoded) == url
|
|
|
|
end
|
2019-06-10 07:34:11 -04:00
|
|
|
|
|
|
|
test "does not change whitelisted urls" do
|
|
|
|
upload_config = Pleroma.Config.get([Pleroma.Upload])
|
|
|
|
media_url = "https://media.pleroma.social"
|
|
|
|
Pleroma.Config.put([Pleroma.Upload, :base_url], media_url)
|
|
|
|
Pleroma.Config.put([:media_proxy, :whitelist], ["media.pleroma.social"])
|
|
|
|
Pleroma.Config.put([:media_proxy, :base_url], "https://cache.pleroma.social")
|
|
|
|
|
|
|
|
url = "#{media_url}/static/logo.png"
|
|
|
|
encoded = url(url)
|
|
|
|
|
|
|
|
assert String.starts_with?(encoded, media_url)
|
|
|
|
|
|
|
|
Pleroma.Config.put([Pleroma.Upload], upload_config)
|
|
|
|
end
|
2018-11-20 11:46:54 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "when disabled" do
|
|
|
|
setup do
|
|
|
|
enabled = Pleroma.Config.get([:media_proxy, :enabled])
|
|
|
|
|
|
|
|
if enabled do
|
|
|
|
Pleroma.Config.put([:media_proxy, :enabled], false)
|
|
|
|
|
|
|
|
on_exit(fn ->
|
|
|
|
Pleroma.Config.put([:media_proxy, :enabled], enabled)
|
|
|
|
:ok
|
|
|
|
end)
|
|
|
|
end
|
|
|
|
|
|
|
|
:ok
|
|
|
|
end
|
|
|
|
|
|
|
|
test "does not encode remote urls" do
|
|
|
|
assert url("https://google.fr") == "https://google.fr"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
defp decode_result(encoded) do
|
|
|
|
[_, "proxy", sig, base64 | _] = URI.parse(encoded).path |> String.split("/")
|
|
|
|
{:ok, decoded} = decode_url(sig, base64)
|
|
|
|
decoded
|
|
|
|
end
|
2019-04-25 19:11:47 -04:00
|
|
|
|
|
|
|
test "mediaproxy whitelist" do
|
|
|
|
Pleroma.Config.put([:media_proxy, :enabled], true)
|
|
|
|
Pleroma.Config.put([:media_proxy, :whitelist], ["google.com", "feld.me"])
|
|
|
|
url = "https://feld.me/foo.png"
|
|
|
|
|
|
|
|
unencoded = url(url)
|
|
|
|
assert unencoded == url
|
|
|
|
end
|
2018-11-20 11:46:54 -05:00
|
|
|
end
|