Sfoglia il codice sorgente

Support activity+json request for activity

tags/v0.9.9
sxsdv1 5 anni fa
parent
commit
20c0dd1e24
3 ha cambiato i file con 57 aggiunte e 14 eliminazioni
  1. +13
    -0
      lib/pleroma/web/activity_pub/activity_pub_controller.ex
  2. +18
    -14
      lib/pleroma/web/ostatus/ostatus_controller.ex
  3. +26
    -0
      test/web/activity_pub/activity_pub_controller_test.exs

+ 13
- 0
lib/pleroma/web/activity_pub/activity_pub_controller.ex Vedi File

@@ -54,6 +54,19 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubController do
end
end

def activity(conn, %{"uuid" => uuid}) do
with ap_id <- o_status_url(conn, :activity, uuid),
%Activity{} = activity <- Activity.normalize(ap_id),
{_, true} <- {:public?, ActivityPub.is_public?(activity)} do
conn
|> put_resp_header("content-type", "application/activity+json")
|> json(ObjectView.render("object.json", %{object: activity}))
else
{:public?, false} ->
{:error, :not_found}
end
end

def following(conn, %{"nickname" => nickname, "page" => page}) do
with %User{} = user <- User.get_cached_by_nickname(nickname),
{:ok, user} <- Pleroma.Web.WebFinger.ensure_keys_present(user) do


+ 18
- 14
lib/pleroma/web/ostatus/ostatus_controller.ex Vedi File

@@ -112,23 +112,27 @@ defmodule Pleroma.Web.OStatus.OStatusController do
end

def activity(conn, %{"uuid" => uuid}) do
with id <- o_status_url(conn, :activity, uuid),
{_, %Activity{} = activity} <- {:activity, Activity.normalize(id)},
{_, true} <- {:public?, ActivityPub.is_public?(activity)},
%User{} = user <- User.get_cached_by_ap_id(activity.data["actor"]) do
case format = get_format(conn) do
"html" -> redirect(conn, to: "/notice/#{activity.id}")
_ -> represent_activity(conn, format, activity, user)
end
if get_format(conn) == "activity+json" do
ActivityPubController.call(conn, :activity)
else
{:public?, false} ->
{:error, :not_found}
with id <- o_status_url(conn, :activity, uuid),
{_, %Activity{} = activity} <- {:activity, Activity.normalize(id)},
{_, true} <- {:public?, ActivityPub.is_public?(activity)},
%User{} = user <- User.get_cached_by_ap_id(activity.data["actor"]) do
case format = get_format(conn) do
"html" -> redirect(conn, to: "/notice/#{activity.id}")
_ -> represent_activity(conn, format, activity, user)
end
else
{:public?, false} ->
{:error, :not_found}

{:activity, nil} ->
{:error, :not_found}
{:activity, nil} ->
{:error, :not_found}

e ->
e
e ->
e
end
end
end



+ 26
- 0
test/web/activity_pub/activity_pub_controller_test.exs Vedi File

@@ -89,6 +89,32 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubControllerTest do
end
end

describe "/activities/:uuid" do
test "it returns a json representation of the activity", %{conn: conn} do
activity = insert(:note_activity)
uuid = String.split(activity.data["id"], "/") |> List.last()

conn =
conn
|> put_req_header("accept", "application/activity+json")
|> get("/activities/#{uuid}")

assert json_response(conn, 200) == ObjectView.render("object.json", %{object: activity})
end

test "it returns 404 for non-public activities", %{conn: conn} do
activity = insert(:direct_note_activity)
uuid = String.split(activity.data["id"], "/") |> List.last()

conn =
conn
|> put_req_header("accept", "application/activity+json")
|> get("/activities/#{uuid}")

assert json_response(conn, 404)
end
end

describe "/inbox" do
test "it inserts an incoming activity into the database", %{conn: conn} do
data = File.read!("test/fixtures/mastodon-post-activity.json") |> Poison.decode!()


Loading…
Annulla
Salva