Browse Source

User: Don't allow local users in remote changesets

issue/2315-poll-notify
lain 3 years ago
parent
commit
222312900e
2 changed files with 20 additions and 0 deletions
  1. +13
    -0
      lib/pleroma/user.ex
  2. +7
    -0
      test/pleroma/user_test.exs

+ 13
- 0
lib/pleroma/user.ex View File

@@ -472,7 +472,20 @@ defmodule Pleroma.User do
|> validate_format(:nickname, @email_regex)
|> validate_length(:bio, max: bio_limit)
|> validate_length(:name, max: name_limit)
|> validate_inclusion(:local, [true])
|> validate_fields(true)
|> validate_non_local()
end

defp validate_non_local(cng) do
local? = get_field(cng, :local)

if local? do
cng
|> add_error(:local, "User is local, can't update with this changeset.")
else
cng
end
end

def update_changeset(struct, params \\ %{}) do


+ 7
- 0
test/pleroma/user_test.exs View File

@@ -895,6 +895,13 @@ defmodule Pleroma.UserTest do
refute cs.valid?
end)
end

test "it is invalid given a local user" do
user = insert(:user)
cs = User.remote_user_changeset(user, %{name: "tom from myspace"})

refute cs.valid?
end
end

describe "followers and friends" do


Loading…
Cancel
Save