From ff4e282aad09954db5d7e234923854a21a002128 Mon Sep 17 00:00:00 2001 From: Mark Felder Date: Tue, 11 Aug 2020 09:52:28 -0500 Subject: [PATCH 1/3] Ensure ap_id column in users table cannot be null --- priv/repo/migrations/20200811143147_ap_id_not_null.exs | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 priv/repo/migrations/20200811143147_ap_id_not_null.exs diff --git a/priv/repo/migrations/20200811143147_ap_id_not_null.exs b/priv/repo/migrations/20200811143147_ap_id_not_null.exs new file mode 100644 index 000000000..3e5d27fe1 --- /dev/null +++ b/priv/repo/migrations/20200811143147_ap_id_not_null.exs @@ -0,0 +1,13 @@ +defmodule Pleroma.Repo.Migrations.ApIdNotNull do + use Ecto.Migration + + def up do + alter table(:users) do + modify(:ap_id, :string, null: false) + end + end + + def down do + :ok + end +end From b89fc1f2274424e7542a133d96373a1738eb53bb Mon Sep 17 00:00:00 2001 From: Mark Felder Date: Wed, 12 Aug 2020 11:13:24 -0500 Subject: [PATCH 2/3] Add warning to the migration --- priv/repo/migrations/20200811143147_ap_id_not_null.exs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/priv/repo/migrations/20200811143147_ap_id_not_null.exs b/priv/repo/migrations/20200811143147_ap_id_not_null.exs index 3e5d27fe1..50f1810b2 100644 --- a/priv/repo/migrations/20200811143147_ap_id_not_null.exs +++ b/priv/repo/migrations/20200811143147_ap_id_not_null.exs @@ -2,6 +2,8 @@ defmodule Pleroma.Repo.Migrations.ApIdNotNull do use Ecto.Migration def up do + Logger.warn("If this migration fails please open an issue at https://git.pleroma.social/pleroma/pleroma/-/issues/new \n") + alter table(:users) do modify(:ap_id, :string, null: false) end From aaf7bd89a71b174ad54040eb9a6106df51ef7ad5 Mon Sep 17 00:00:00 2001 From: lain Date: Thu, 13 Aug 2020 12:32:05 +0200 Subject: [PATCH 3/3] Migrations: Fix Logger requirements. --- priv/repo/migrations/20200811143147_ap_id_not_null.exs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/priv/repo/migrations/20200811143147_ap_id_not_null.exs b/priv/repo/migrations/20200811143147_ap_id_not_null.exs index 50f1810b2..df649c7ca 100644 --- a/priv/repo/migrations/20200811143147_ap_id_not_null.exs +++ b/priv/repo/migrations/20200811143147_ap_id_not_null.exs @@ -1,8 +1,12 @@ defmodule Pleroma.Repo.Migrations.ApIdNotNull do use Ecto.Migration + require Logger + def up do - Logger.warn("If this migration fails please open an issue at https://git.pleroma.social/pleroma/pleroma/-/issues/new \n") + Logger.warn( + "If this migration fails please open an issue at https://git.pleroma.social/pleroma/pleroma/-/issues/new \n" + ) alter table(:users) do modify(:ap_id, :string, null: false)