Browse Source

Make error message about author's inability to vote more sensible

tags/v1.1.4
rinpatch 5 years ago
parent
commit
2fe3a20638
2 changed files with 2 additions and 2 deletions
  1. +1
    -1
      lib/pleroma/web/common_api/common_api.ex
  2. +1
    -1
      test/web/mastodon_api/mastodon_api_controller_test.exs

+ 1
- 1
lib/pleroma/web/common_api/common_api.ex View File

@@ -144,7 +144,7 @@ defmodule Pleroma.Web.CommonAPI do
object = Object.get_cached_by_ap_id(object.data["id"])
{:ok, answer_activities, object}
else
{:author, _} -> {:error, "Already voted"}
{:author, _} -> {:error, "Poll's author can't vote"}
{:existing_votes, _} -> {:error, "Already voted"}
{:choice_check, {_, false}} -> {:error, "Invalid indices"}
{:count_check, false} -> {:error, "Too many choices"}


+ 1
- 1
test/web/mastodon_api/mastodon_api_controller_test.exs View File

@@ -3649,7 +3649,7 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIControllerTest do
assert conn
|> assign(:user, user)
|> post("/api/v1/polls/#{object.id}/votes", %{"choices" => [1]})
|> json_response(422) == %{"error" => "Already voted"}
|> json_response(422) == %{"error" => "Poll's author can't vote"}

object = Object.get_by_id(object.id)



Loading…
Cancel
Save