Bladeren bron

tests: remove a useless sleep in rate limiter tests

It was used to check that authenticated and unauthenticated users have
different limits. Instead of sleeping a super low limit for
unauthenticated users was set, preventing them from doing 5 requests in
the first place.
chore/benchmark-dedicated-db
rinpatch 4 jaren geleden
bovenliggende
commit
54029fe212
2 gewijzigde bestanden met toevoegingen van 3 en 13 verwijderingen
  1. +1
    -1
      test/conversation/participation_test.exs
  2. +2
    -12
      test/plugs/rate_limiter_test.exs

+ 1
- 1
test/conversation/participation_test.exs Bestand weergeven

@@ -99,7 +99,7 @@ defmodule Pleroma.Conversation.ParticipationTest do

assert participation.user_id == user.id
assert participation.conversation_id == conversation.id
# Needed because updated_at is accurate down to a second
:timer.sleep(1000)



+ 2
- 12
test/plugs/rate_limiter_test.exs Bestand weergeven

@@ -145,9 +145,9 @@ defmodule Pleroma.Plugs.RateLimiterTest do
test "can have limits seperate from unauthenticated connections" do
limiter_name = :test_authenticated

scale = 1000
scale = 50
limit = 5
Pleroma.Config.put([:rate_limit, limiter_name], [{1, 10}, {scale, limit}])
Pleroma.Config.put([:rate_limit, limiter_name], [{1000, 1}, {scale, limit}])

opts = RateLimiter.init(name: limiter_name)

@@ -164,16 +164,6 @@ defmodule Pleroma.Plugs.RateLimiterTest do

assert %{"error" => "Throttled"} = Phoenix.ConnTest.json_response(conn, :too_many_requests)
assert conn.halted

Process.sleep(1550)

conn = conn(:get, "/") |> assign(:user, user)
conn = RateLimiter.call(conn, opts)
assert {1, 4} = RateLimiter.inspect_bucket(conn, limiter_name, opts)

refute conn.status == Plug.Conn.Status.code(:too_many_requests)
refute conn.resp_body
refute conn.halted
end

test "diffrerent users are counted independently" do


Laden…
Annuleren
Opslaan