Transmogrifier: Use a simpler way to get mentions.

lib/pleroma/web/activity_pub/transmogrifier.ex

@@ -1045,10 +1045,14 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     Map.put(object, "tag", tags)
   end
 
+  # TODO These should be added on our side on insertion, it doesn't make much
+  # sense to regenerate these all the time
   def add_mention_tags(object) do
-    {enabled_receivers, disabled_receivers} = Utils.get_notified_from_object(object)
-    potential_receivers = enabled_receivers ++ disabled_receivers
-    mentions = Enum.map(potential_receivers, &build_mention_tag/1)
+    to = object["to"] || []
+    cc = object["cc"] || []
+    mentioned = User.get_users_from_set(to ++ cc, local_only: false)
+
+    mentions = Enum.map(mentioned, &build_mention_tag/1)
 
     tags = object["tag"] || []
     Map.put(object, "tag", tags ++ mentions)

test/web/activity_pub/transmogrifier_test.exs

@@ -1094,7 +1094,10 @@ defmodule Pleroma.Web.ActivityPub.TransmogrifierTest do
       {:ok, activity} =
         CommonAPI.post(user, %{status: "hey, @#{other_user.nickname}, how are ya? #2hu"})
 
+      with_mock Pleroma.Notification,
+        get_notified_from_activity: fn _, _ -> [] end do
         {:ok, modified} = Transmogrifier.prepare_outgoing(activity.data)
+
         object = modified["object"]
 
         expected_mention = %{
@@ -1109,9 +1112,11 @@ defmodule Pleroma.Web.ActivityPub.TransmogrifierTest do
           "name" => "#2hu"
         }
 
+        refute called(Pleroma.Notification.get_notified_from_activity(:_, :_))
         assert Enum.member?(object["tag"], expected_tag)
         assert Enum.member?(object["tag"], expected_mention)
       end
+    end
 
     test "it adds the sensitive property" do
       user = insert(:user)