squeegily/pleroma
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Join on preloads to avoid N+1 queries

Browse Source
This commit is contained in:
href 2019-01-26 15:55:53 +01:00
parent 6383fa3a5d
commit 8018ae7ae5
No known key found for this signature in database
GPG Key ID: EE8296C1A152C325
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/pleroma/notification.ex
View File

@ -35,7 +35,8 @@ defmodule Pleroma.Notification do
n in Notification, n in Notification,
where: n.user_id == ^user.id, where: n.user_id == ^user.id,
order_by: [desc: n.id], order_by: [desc: n.id],
preload: [:activity], join: activity in assoc(n, :activity),
preload: [activity: activity],
limit: 20 limit: 20
) )
@ -66,7 +67,8 @@ defmodule Pleroma.Notification do
from( from(
n in Notification, n in Notification,
where: n.id == ^id, where: n.id == ^id,
preload: [:activity] join: activity in assoc(n, :activity),
preload: [activity: activity]
) )
notification = Repo.one(query) notification = Repo.one(query)

7
lib/pleroma/plugs/oauth_plug.ex
View File

@ -33,7 +33,12 @@ defmodule Pleroma.Plugs.OAuthPlug do
# #
@spec fetch_user_and_token(String.t()) :: {:ok, User.t(), Token.t()} | nil @spec fetch_user_and_token(String.t()) :: {:ok, User.t(), Token.t()} | nil
defp fetch_user_and_token(token) do defp fetch_user_and_token(token) do
query = from(q in Token, where: q.token == ^token, preload: [:user]) query =
from(t in Token,
where: t.token == ^token,
join: user in assoc(t, :user),
preload: [user: user]
)
with %Token{user: %{info: %{deactivated: false} = _} = user} = token_record <- Repo.one(query) do with %Token{user: %{info: %{deactivated: false} = _} = user} = token_record <- Repo.one(query) do
{:ok, user, token_record} {:ok, user, token_record}