Browse Source

Fix never matching clause

`length/1` is only used with lists.
feature/compile_get
rinpatch 4 years ago
parent
commit
a21340caa1
3 changed files with 3 additions and 1 deletions
  1. +1
    -0
      lib/pleroma/clippy.ex
  2. +1
    -0
      lib/pleroma/html.ex
  3. +1
    -1
      lib/pleroma/web/activity_pub/transmogrifier.ex

+ 1
- 0
lib/pleroma/clippy.ex View File

@@ -4,6 +4,7 @@

defmodule Pleroma.Clippy do
@moduledoc false

# No software is complete until they have a Clippy implementation.
# A ballmer peak _may_ be required to change this module.



+ 1
- 0
lib/pleroma/html.ex View File

@@ -163,6 +163,7 @@ defmodule Pleroma.HTML.Scrubber.Default do

require FastSanitize.Sanitizer.Meta
alias FastSanitize.Sanitizer.Meta

# credo:disable-for-previous-line
# No idea how to fix this one…



+ 1
- 1
lib/pleroma/web/activity_pub/transmogrifier.ex View File

@@ -387,7 +387,7 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
def handle_incoming(%{"id" => nil}, _options), do: :error
def handle_incoming(%{"id" => ""}, _options), do: :error
# length of https:// = 8, should validate better, but good enough for now.
def handle_incoming(%{"id" => id}, _options) when not (is_binary(id) and length(id) > 8),
def handle_incoming(%{"id" => id}, _options) when is_binary(id) and byte_size(id) < 8,
do: :error

# TODO: validate those with a Ecto scheme


Loading…
Cancel
Save