squeegily/pleroma
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

DeleteValidator: Mastodon sends unaddressed deletes.

Browse Source
This commit is contained in:
lain 2020-04-30 14:37:14 +02:00
parent bd219ba7e8
commit db184a8eb4
2 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/pleroma/web/activity_pub/object_validators/delete_validator.ex
View File

@ -32,7 +32,6 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidators.DeleteValidator do
|> validate_inclusion(:type, ["Delete"]) |> validate_inclusion(:type, ["Delete"])
|> validate_same_domain() |> validate_same_domain()
|> validate_object_presence() |> validate_object_presence()
|> validate_recipients_presence()
end end
def validate_same_domain(cng) do def validate_same_domain(cng) do

14
test/web/activity_pub/object_validator_test.exs
View File

@ -59,20 +59,6 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidatorTest do
assert {:actor, {"is not allowed to delete object", []}} in cng.errors assert {:actor, {"is not allowed to delete object", []}} in cng.errors
end end
test "it's invalid if all the recipient fields are empty", %{
valid_post_delete: valid_post_delete
} do
empty_recipients =
valid_post_delete
|> Map.put("to", [])
|> Map.put("cc", [])
{:error, cng} = ObjectValidator.validate(empty_recipients, [])
assert {:to, {"no recipients in any field", []}} in cng.errors
assert {:cc, {"no recipients in any field", []}} in cng.errors
end
end end
describe "likes" do describe "likes" do