[#468] OAuth2 scopes Closes #468 See merge request pleroma/pleroma!799tags/v1.1.4
@@ -0,0 +1,41 @@ | |||
# Pleroma: A lightweight social networking server | |||
# Copyright © 2017-2019 Pleroma Authors <https://pleroma.social/> | |||
# SPDX-License-Identifier: AGPL-3.0-only | |||
defmodule Pleroma.Plugs.OAuthScopesPlug do | |||
import Plug.Conn | |||
@behaviour Plug | |||
def init(%{scopes: _} = options), do: options | |||
def call(%Plug.Conn{assigns: assigns} = conn, %{scopes: scopes} = options) do | |||
op = options[:op] || :| | |||
token = assigns[:token] | |||
cond do | |||
is_nil(token) -> | |||
conn | |||
op == :| && scopes -- token.scopes != scopes -> | |||
conn | |||
op == :& && scopes -- token.scopes == [] -> | |||
conn | |||
options[:fallback] == :proceed_unauthenticated -> | |||
conn | |||
|> assign(:user, nil) | |||
|> assign(:token, nil) | |||
true -> | |||
missing_scopes = scopes -- token.scopes | |||
error_message = "Insufficient permissions: #{Enum.join(missing_scopes, " #{op} ")}." | |||
conn | |||
|> put_resp_content_type("application/json") | |||
|> send_resp(403, Jason.encode!(%{error: error_message})) | |||
|> halt() | |||
end | |||
end | |||
end |
@@ -5,6 +5,11 @@ | |||
defmodule Pleroma.Web.ControllerHelper do | |||
use Pleroma.Web, :controller | |||
def oauth_scopes(params, default) do | |||
# Note: `scopes` is used by Mastodon — supporting it but sticking to OAuth's standard `scope` wherever we control it | |||
Pleroma.Web.OAuth.parse_scopes(params["scope"] || params["scopes"], default) | |||
end | |||
def json_response(conn, status, json) do | |||
conn | |||
|> put_status(status) | |||
@@ -30,7 +30,9 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIController do | |||
alias Pleroma.Web.OAuth.Authorization | |||
alias Pleroma.Web.OAuth.Token | |||
import Pleroma.Web.ControllerHelper, only: [oauth_scopes: 2] | |||
import Ecto.Query | |||
require Logger | |||
@httpoison Application.get_env(:pleroma, :httpoison) | |||
@@ -39,7 +41,14 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIController do | |||
action_fallback(:errors) | |||
def create_app(conn, params) do | |||
with cs <- App.register_changeset(%App{}, params), | |||
scopes = oauth_scopes(params, ["read"]) | |||
app_attrs = | |||
params | |||
|> Map.drop(["scope", "scopes"]) | |||
|> Map.put("scopes", scopes) | |||
with cs <- App.register_changeset(%App{}, app_attrs), | |||
false <- cs.changes[:client_name] == @local_mastodon_name, | |||
{:ok, app} <- Repo.insert(cs) do | |||
res = %{ | |||
@@ -1254,7 +1263,7 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIController do | |||
response_type: "code", | |||
client_id: app.client_id, | |||
redirect_uri: ".", | |||
scope: app.scopes | |||
scope: Enum.join(app.scopes, " ") | |||
) | |||
conn | |||
@@ -1264,12 +1273,26 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIController do | |||
defp get_or_make_app() do | |||
find_attrs = %{client_name: @local_mastodon_name, redirect_uris: "."} | |||
scopes = ["read", "write", "follow", "push"] | |||
with %App{} = app <- Repo.get_by(App, find_attrs) do | |||
{:ok, app} = | |||
if app.scopes == scopes do | |||
{:ok, app} | |||
else | |||
app | |||
|> Ecto.Changeset.change(%{scopes: scopes}) | |||
|> Repo.update() | |||
end | |||
{:ok, app} | |||
else | |||
_e -> | |||
cs = App.register_changeset(%App{}, Map.put(find_attrs, :scopes, "read,write,follow")) | |||
cs = | |||
App.register_changeset( | |||
%App{}, | |||
Map.put(find_attrs, :scopes, scopes) | |||
) | |||
Repo.insert(cs) | |||
end | |||
@@ -0,0 +1,20 @@ | |||
# Pleroma: A lightweight social networking server | |||
# Copyright © 2017-2019 Pleroma Authors <https://pleroma.social/> | |||
# SPDX-License-Identifier: AGPL-3.0-only | |||
defmodule Pleroma.Web.OAuth do | |||
def parse_scopes(scopes, _default) when is_list(scopes) do | |||
Enum.filter(scopes, &(&1 not in [nil, ""])) | |||
end | |||
def parse_scopes(scopes, default) when is_binary(scopes) do | |||
scopes | |||
|> String.trim() | |||
|> String.split(~r/[\s,]+/) | |||
|> parse_scopes(default) | |||
end | |||
def parse_scopes(_, default) do | |||
default | |||
end | |||
end |
@@ -9,7 +9,7 @@ defmodule Pleroma.Web.OAuth.App do | |||
schema "apps" do | |||
field(:client_name, :string) | |||
field(:redirect_uris, :string) | |||
field(:scopes, :string) | |||
field(:scopes, {:array, :string}, default: []) | |||
field(:website, :string) | |||
field(:client_id, :string) | |||
field(:client_secret, :string) | |||
@@ -15,6 +15,7 @@ defmodule Pleroma.Web.OAuth.Authorization do | |||
schema "oauth_authorizations" do | |||
field(:token, :string) | |||
field(:scopes, {:array, :string}, default: []) | |||
field(:valid_until, :naive_datetime) | |||
field(:used, :boolean, default: false) | |||
belongs_to(:user, Pleroma.User, type: Pleroma.FlakeId) | |||
@@ -23,7 +24,8 @@ defmodule Pleroma.Web.OAuth.Authorization do | |||
timestamps() | |||
end | |||
def create_authorization(%App{} = app, %User{} = user) do | |||
def create_authorization(%App{} = app, %User{} = user, scopes \\ nil) do | |||
scopes = scopes || app.scopes | |||
token = :crypto.strong_rand_bytes(32) |> Base.url_encode64(padding: false) | |||
authorization = %Authorization{ | |||
@@ -31,6 +33,7 @@ defmodule Pleroma.Web.OAuth.Authorization do | |||
used: false, | |||
user_id: user.id, | |||
app_id: app.id, | |||
scopes: scopes, | |||
valid_until: NaiveDateTime.add(NaiveDateTime.utc_now(), 60 * 10) | |||
} | |||
@@ -12,16 +12,23 @@ defmodule Pleroma.Web.OAuth.OAuthController do | |||
alias Pleroma.User | |||
alias Comeonin.Pbkdf2 | |||
import Pleroma.Web.ControllerHelper, only: [oauth_scopes: 2] | |||
plug(:fetch_session) | |||
plug(:fetch_flash) | |||
action_fallback(Pleroma.Web.OAuth.FallbackController) | |||
def authorize(conn, params) do | |||
app = Repo.get_by(App, client_id: params["client_id"]) | |||
available_scopes = (app && app.scopes) || [] | |||
scopes = oauth_scopes(params, nil) || available_scopes | |||
render(conn, "show.html", %{ | |||
response_type: params["response_type"], | |||
client_id: params["client_id"], | |||
scope: params["scope"], | |||
available_scopes: available_scopes, | |||
scopes: scopes, | |||
redirect_uri: params["redirect_uri"], | |||
state: params["state"] | |||
}) | |||
@@ -34,14 +41,18 @@ defmodule Pleroma.Web.OAuth.OAuthController do | |||
"password" => password, | |||
"client_id" => client_id, | |||
"redirect_uri" => redirect_uri | |||
} = params | |||
} = auth_params | |||
}) do | |||
with %User{} = user <- User.get_by_nickname_or_email(name), | |||
true <- Pbkdf2.checkpw(password, user.password_hash), | |||
{:auth_active, true} <- {:auth_active, User.auth_active?(user)}, | |||
%App{} = app <- Repo.get_by(App, client_id: client_id), | |||
true <- redirect_uri in String.split(app.redirect_uris), | |||
{:ok, auth} <- Authorization.create_authorization(app, user) do | |||
scopes <- oauth_scopes(auth_params, []), | |||
{:unsupported_scopes, []} <- {:unsupported_scopes, scopes -- app.scopes}, | |||
# Note: `scope` param is intentionally not optional in this context | |||
{:missing_scopes, false} <- {:missing_scopes, scopes == []}, | |||
{:auth_active, true} <- {:auth_active, User.auth_active?(user)}, | |||
{:ok, auth} <- Authorization.create_authorization(app, user, scopes) do | |||
# Special case: Local MastodonFE. | |||
redirect_uri = | |||
if redirect_uri == "." do | |||
@@ -62,8 +73,8 @@ defmodule Pleroma.Web.OAuth.OAuthController do | |||
url_params = %{:code => auth.token} | |||
url_params = | |||
if params["state"] do | |||
Map.put(url_params, :state, params["state"]) | |||
if auth_params["state"] do | |||
Map.put(url_params, :state, auth_params["state"]) | |||
else | |||
url_params | |||
end | |||
@@ -73,19 +84,23 @@ defmodule Pleroma.Web.OAuth.OAuthController do | |||
redirect(conn, external: url) | |||
end | |||
else | |||
{scopes_issue, _} when scopes_issue in [:unsupported_scopes, :missing_scopes] -> | |||
conn | |||
|> put_flash(:error, "Permissions not specified.") | |||
|> put_status(:unauthorized) | |||
|> authorize(auth_params) | |||
{:auth_active, false} -> | |||
conn | |||
|> put_flash(:error, "Account confirmation pending") | |||
|> put_flash(:error, "Account confirmation pending.") | |||
|> put_status(:forbidden) | |||
|> authorize(params) | |||
|> authorize(auth_params) | |||
error -> | |||
error | |||
end | |||
end | |||
# TODO | |||
# - proper scope handling | |||
def token_exchange(conn, %{"grant_type" => "authorization_code"} = params) do | |||
with %App{} = app <- get_app_from_request(conn, params), | |||
fixed_token = fix_padding(params["code"]), | |||
@@ -99,7 +114,7 @@ defmodule Pleroma.Web.OAuth.OAuthController do | |||
refresh_token: token.refresh_token, | |||
created_at: DateTime.to_unix(inserted_at), | |||
expires_in: 60 * 10, | |||
scope: "read write follow" | |||
scope: Enum.join(token.scopes) | |||
} | |||
json(conn, response) | |||
@@ -110,8 +125,6 @@ defmodule Pleroma.Web.OAuth.OAuthController do | |||
end | |||
end | |||
# TODO | |||
# - investigate a way to verify the user wants to grant read/write/follow once scope handling is done | |||
def token_exchange( | |||
conn, | |||
%{"grant_type" => "password", "username" => name, "password" => password} = params | |||
@@ -120,14 +133,17 @@ defmodule Pleroma.Web.OAuth.OAuthController do | |||
%User{} = user <- User.get_by_nickname_or_email(name), | |||
true <- Pbkdf2.checkpw(password, user.password_hash), | |||
{:auth_active, true} <- {:auth_active, User.auth_active?(user)}, | |||
{:ok, auth} <- Authorization.create_authorization(app, user), | |||
scopes <- oauth_scopes(params, app.scopes), | |||
[] <- scopes -- app.scopes, | |||
true <- Enum.any?(scopes), | |||
{:ok, auth} <- Authorization.create_authorization(app, user, scopes), | |||
{:ok, token} <- Token.exchange_token(app, auth) do | |||
response = %{ | |||
token_type: "Bearer", | |||
access_token: token.token, | |||
refresh_token: token.refresh_token, | |||
expires_in: 60 * 10, | |||
scope: "read write follow" | |||
scope: Enum.join(token.scopes, " ") | |||
} | |||
json(conn, response) | |||
@@ -16,6 +16,7 @@ defmodule Pleroma.Web.OAuth.Token do | |||
schema "oauth_tokens" do | |||
field(:token, :string) | |||
field(:refresh_token, :string) | |||
field(:scopes, {:array, :string}, default: []) | |||
field(:valid_until, :naive_datetime) | |||
belongs_to(:user, Pleroma.User, type: Pleroma.FlakeId) | |||
belongs_to(:app, App) | |||
@@ -26,17 +27,19 @@ defmodule Pleroma.Web.OAuth.Token do | |||
def exchange_token(app, auth) do | |||
with {:ok, auth} <- Authorization.use_token(auth), | |||
true <- auth.app_id == app.id do | |||
create_token(app, Repo.get(User, auth.user_id)) | |||
create_token(app, Repo.get(User, auth.user_id), auth.scopes) | |||
end | |||
end | |||
def create_token(%App{} = app, %User{} = user) do | |||
def create_token(%App{} = app, %User{} = user, scopes \\ nil) do | |||
scopes = scopes || app.scopes | |||
token = :crypto.strong_rand_bytes(32) |> Base.url_encode64(padding: false) | |||
refresh_token = :crypto.strong_rand_bytes(32) |> Base.url_encode64(padding: false) | |||
token = %Token{ | |||
token: token, | |||
refresh_token: refresh_token, | |||
scopes: scopes, | |||
user_id: user.id, | |||
app_id: app.id, | |||
valid_until: NaiveDateTime.add(NaiveDateTime.utc_now(), 60 * 10) | |||
@@ -74,6 +74,29 @@ defmodule Pleroma.Web.Router do | |||
plug(Pleroma.Plugs.EnsureUserKeyPlug) | |||
end | |||
pipeline :oauth_read_or_unauthenticated do | |||
plug(Pleroma.Plugs.OAuthScopesPlug, %{ | |||
scopes: ["read"], | |||
fallback: :proceed_unauthenticated | |||
}) | |||
end | |||
pipeline :oauth_read do | |||
plug(Pleroma.Plugs.OAuthScopesPlug, %{scopes: ["read"]}) | |||
end | |||
pipeline :oauth_write do | |||
plug(Pleroma.Plugs.OAuthScopesPlug, %{scopes: ["write"]}) | |||
end | |||
pipeline :oauth_follow do | |||
plug(Pleroma.Plugs.OAuthScopesPlug, %{scopes: ["follow"]}) | |||
end | |||
pipeline :oauth_push do | |||
plug(Pleroma.Plugs.OAuthScopesPlug, %{scopes: ["push"]}) | |||
end | |||
pipeline :well_known do | |||
plug(:accepts, ["json", "jrd+json", "xml", "xrd+xml"]) | |||
end | |||
@@ -101,6 +124,7 @@ defmodule Pleroma.Web.Router do | |||
scope "/api/pleroma", Pleroma.Web.TwitterAPI do | |||
pipe_through(:pleroma_api) | |||
get("/password_reset/:token", UtilController, :show_password_reset) | |||
post("/password_reset", UtilController, :password_reset) | |||
get("/emoji", UtilController, :emoji) | |||
@@ -113,7 +137,8 @@ defmodule Pleroma.Web.Router do | |||
end | |||
scope "/api/pleroma/admin", Pleroma.Web.AdminAPI do | |||
pipe_through(:admin_api) | |||
pipe_through([:admin_api, :oauth_write]) | |||
delete("/user", AdminAPIController, :user_delete) | |||
post("/user", AdminAPIController, :user_create) | |||
put("/users/tag", AdminAPIController, :tag_users) | |||
@@ -137,17 +162,32 @@ defmodule Pleroma.Web.Router do | |||
scope "/", Pleroma.Web.TwitterAPI do | |||
pipe_through(:pleroma_html) | |||
get("/ostatus_subscribe", UtilController, :remote_follow) | |||
post("/ostatus_subscribe", UtilController, :do_remote_follow) | |||
post("/main/ostatus", UtilController, :remote_subscribe) | |||
get("/ostatus_subscribe", UtilController, :remote_follow) | |||
scope [] do | |||
pipe_through(:oauth_follow) | |||
post("/ostatus_subscribe", UtilController, :do_remote_follow) | |||
end | |||
end | |||
scope "/api/pleroma", Pleroma.Web.TwitterAPI do | |||
pipe_through(:authenticated_api) | |||
post("/blocks_import", UtilController, :blocks_import) | |||
post("/follow_import", UtilController, :follow_import) | |||
post("/change_password", UtilController, :change_password) | |||
post("/delete_account", UtilController, :delete_account) | |||
scope [] do | |||
pipe_through(:oauth_write) | |||
post("/change_password", UtilController, :change_password) | |||
post("/delete_account", UtilController, :delete_account) | |||
end | |||
scope [] do | |||
pipe_through(:oauth_follow) | |||
post("/blocks_import", UtilController, :blocks_import) | |||
post("/follow_import", UtilController, :follow_import) | |||
end | |||
end | |||
scope "/oauth", Pleroma.Web.OAuth do | |||
@@ -160,124 +200,154 @@ defmodule Pleroma.Web.Router do | |||
scope "/api/v1", Pleroma.Web.MastodonAPI do | |||
pipe_through(:authenticated_api) | |||
patch("/accounts/update_credentials", MastodonAPIController, :update_credentials) | |||
get("/accounts/verify_credentials", MastodonAPIController, :verify_credentials) | |||
get("/accounts/relationships", MastodonAPIController, :relationships) | |||
get("/accounts/search", MastodonAPIController, :account_search) | |||
post("/accounts/:id/follow", MastodonAPIController, :follow) | |||
post("/accounts/:id/unfollow", MastodonAPIController, :unfollow) | |||
post("/accounts/:id/block", MastodonAPIController, :block) | |||
post("/accounts/:id/unblock", MastodonAPIController, :unblock) | |||
post("/accounts/:id/mute", MastodonAPIController, :mute) | |||
post("/accounts/:id/unmute", MastodonAPIController, :unmute) | |||
get("/accounts/:id/lists", MastodonAPIController, :account_lists) | |||
scope [] do | |||
pipe_through(:oauth_read) | |||
get("/accounts/verify_credentials", MastodonAPIController, :verify_credentials) | |||
get("/follow_requests", MastodonAPIController, :follow_requests) | |||
post("/follow_requests/:id/authorize", MastodonAPIController, :authorize_follow_request) | |||
post("/follow_requests/:id/reject", MastodonAPIController, :reject_follow_request) | |||
get("/accounts/relationships", MastodonAPIController, :relationships) | |||
get("/accounts/search", MastodonAPIController, :account_search) | |||
post("/follows", MastodonAPIController, :follow) | |||
get("/accounts/:id/lists", MastodonAPIController, :account_lists) | |||
get("/blocks", MastodonAPIController, :blocks) | |||
get("/follow_requests", MastodonAPIController, :follow_requests) | |||
get("/blocks", MastodonAPIController, :blocks) | |||
get("/mutes", MastodonAPIController, :mutes) | |||
get("/mutes", MastodonAPIController, :mutes) | |||
get("/timelines/home", MastodonAPIController, :home_timeline) | |||
get("/timelines/direct", MastodonAPIController, :dm_timeline) | |||
get("/timelines/home", MastodonAPIController, :home_timeline) | |||
get("/favourites", MastodonAPIController, :favourites) | |||
get("/bookmarks", MastodonAPIController, :bookmarks) | |||
get("/timelines/direct", MastodonAPIController, :dm_timeline) | |||
post("/notifications/clear", MastodonAPIController, :clear_notifications) | |||
post("/notifications/dismiss", MastodonAPIController, :dismiss_notification) | |||
get("/notifications", MastodonAPIController, :notifications) | |||
get("/notifications/:id", MastodonAPIController, :get_notification) | |||
get("/favourites", MastodonAPIController, :favourites) | |||
get("/bookmarks", MastodonAPIController, :bookmarks) | |||
get("/lists", MastodonAPIController, :get_lists) | |||
get("/lists/:id", MastodonAPIController, :get_list) | |||
get("/lists/:id/accounts", MastodonAPIController, :list_accounts) | |||
post("/statuses", MastodonAPIController, :post_status) | |||
delete("/statuses/:id", MastodonAPIController, :delete_status) | |||
get("/domain_blocks", MastodonAPIController, :domain_blocks) | |||
post("/statuses/:id/reblog", MastodonAPIController, :reblog_status) | |||
post("/statuses/:id/unreblog", MastodonAPIController, :unreblog_status) | |||
post("/statuses/:id/favourite", MastodonAPIController, :fav_status) | |||
post("/statuses/:id/unfavourite", MastodonAPIController, :unfav_status) | |||
post("/statuses/:id/pin", MastodonAPIController, :pin_status) | |||
post("/statuses/:id/unpin", MastodonAPIController, :unpin_status) | |||
post("/statuses/:id/bookmark", MastodonAPIController, :bookmark_status) | |||
post("/statuses/:id/unbookmark", MastodonAPIController, :unbookmark_status) | |||
post("/statuses/:id/mute", MastodonAPIController, :mute_conversation) | |||
post("/statuses/:id/unmute", MastodonAPIController, :unmute_conversation) | |||
get("/filters", MastodonAPIController, :get_filters) | |||
post("/notifications/clear", MastodonAPIController, :clear_notifications) | |||
post("/notifications/dismiss", MastodonAPIController, :dismiss_notification) | |||
get("/notifications", MastodonAPIController, :notifications) | |||
get("/notifications/:id", MastodonAPIController, :get_notification) | |||
get("/suggestions", MastodonAPIController, :suggestions) | |||
post("/media", MastodonAPIController, :upload) | |||
put("/media/:id", MastodonAPIController, :update_media) | |||
get("/endorsements", MastodonAPIController, :empty_array) | |||
get("/lists", MastodonAPIController, :get_lists) | |||
get("/lists/:id", MastodonAPIController, :get_list) | |||
delete("/lists/:id", MastodonAPIController, :delete_list) | |||
post("/lists", MastodonAPIController, :create_list) | |||
put("/lists/:id", MastodonAPIController, :rename_list) | |||
get("/lists/:id/accounts", MastodonAPIController, :list_accounts) | |||
post("/lists/:id/accounts", MastodonAPIController, :add_to_list) | |||
delete("/lists/:id/accounts", MastodonAPIController, :remove_from_list) | |||
get("/pleroma/flavour", MastodonAPIController, :get_flavour) | |||
end | |||
scope [] do | |||
pipe_through(:oauth_write) | |||
patch("/accounts/update_credentials", MastodonAPIController, :update_credentials) | |||
get("/domain_blocks", MastodonAPIController, :domain_blocks) | |||
post("/domain_blocks", MastodonAPIController, :block_domain) | |||
delete("/domain_blocks", MastodonAPIController, :unblock_domain) | |||
post("/statuses", MastodonAPIController, :post_status) | |||
delete("/statuses/:id", MastodonAPIController, :delete_status) | |||
get("/filters", MastodonAPIController, :get_filters) | |||
post("/filters", MastodonAPIController, :create_filter) | |||
get("/filters/:id", MastodonAPIController, :get_filter) | |||
put("/filters/:id", MastodonAPIController, :update_filter) | |||
delete("/filters/:id", MastodonAPIController, :delete_filter) | |||
post("/statuses/:id/reblog", MastodonAPIController, :reblog_status) | |||
post("/statuses/:id/unreblog", MastodonAPIController, :unreblog_status) | |||
post("/statuses/:id/favourite", MastodonAPIController, :fav_status) | |||
post("/statuses/:id/unfavourite", MastodonAPIController, :unfav_status) | |||
post("/statuses/:id/pin", MastodonAPIController, :pin_status) | |||
post("/statuses/:id/unpin", MastodonAPIController, :unpin_status) | |||
post("/statuses/:id/bookmark", MastodonAPIController, :bookmark_status) | |||
post("/statuses/:id/unbookmark", MastodonAPIController, :unbookmark_status) | |||
post("/statuses/:id/mute", MastodonAPIController, :mute_conversation) | |||
post("/statuses/:id/unmute", MastodonAPIController, :unmute_conversation) | |||
post("/push/subscription", MastodonAPIController, :create_push_subscription) | |||
get("/push/subscription", MastodonAPIController, :get_push_subscription) | |||
put("/push/subscription", MastodonAPIController, :update_push_subscription) | |||
delete("/push/subscription", MastodonAPIController, :delete_push_subscription) | |||
post("/media", MastodonAPIController, :upload) | |||
put("/media/:id", MastodonAPIController, :update_media) | |||
get("/suggestions", MastodonAPIController, :suggestions) | |||
delete("/lists/:id", MastodonAPIController, :delete_list) | |||
post("/lists", MastodonAPIController, :create_list) | |||
put("/lists/:id", MastodonAPIController, :rename_list) | |||
get("/endorsements", MastodonAPIController, :empty_array) | |||
post("/lists/:id/accounts", MastodonAPIController, :add_to_list) | |||
delete("/lists/:id/accounts", MastodonAPIController, :remove_from_list) | |||
post("/pleroma/flavour/:flavour", MastodonAPIController, :set_flavour) | |||
get("/pleroma/flavour", MastodonAPIController, :get_flavour) | |||
post("/filters", MastodonAPIController, :create_filter) | |||
get("/filters/:id", MastodonAPIController, :get_filter) | |||
put("/filters/:id", MastodonAPIController, :update_filter) | |||
delete("/filters/:id", MastodonAPIController, :delete_filter) | |||
post("/pleroma/flavour/:flavour", MastodonAPIController, :set_flavour) | |||
end | |||
scope [] do | |||
pipe_through(:oauth_follow) | |||
post("/follows", MastodonAPIController, :follow) | |||
post("/accounts/:id/follow", MastodonAPIController, :follow) | |||
post("/accounts/:id/unfollow", MastodonAPIController, :unfollow) | |||
post("/accounts/:id/block", MastodonAPIController, :block) | |||
post("/accounts/:id/unblock", MastodonAPIController, :unblock) | |||
post("/accounts/:id/mute", MastodonAPIController, :mute) | |||
post("/accounts/:id/unmute", MastodonAPIController, :unmute) | |||
post("/follow_requests/:id/authorize", MastodonAPIController, :authorize_follow_request) | |||
post("/follow_requests/:id/reject", MastodonAPIController, :reject_follow_request) | |||
post("/domain_blocks", MastodonAPIController, :block_domain) | |||
delete("/domain_blocks", MastodonAPIController, :unblock_domain) | |||
end | |||
scope [] do | |||
pipe_through(:oauth_push) | |||
post("/push/subscription", MastodonAPIController, :create_push_subscription) | |||
get("/push/subscription", MastodonAPIController, :get_push_subscription) | |||
put("/push/subscription", MastodonAPIController, :update_push_subscription) | |||
delete("/push/subscription", MastodonAPIController, :delete_push_subscription) | |||
end | |||
end | |||
scope "/api/web", Pleroma.Web.MastodonAPI do | |||
pipe_through(:authenticated_api) | |||
pipe_through([:authenticated_api, :oauth_write]) | |||
put("/settings", MastodonAPIController, :put_settings) | |||
end | |||
scope "/api/v1", Pleroma.Web.MastodonAPI do | |||
pipe_through(:api) | |||
get("/instance", MastodonAPIController, :masto_instance) | |||
get("/instance/peers", MastodonAPIController, :peers) | |||
post("/apps", MastodonAPIController, :create_app) | |||
get("/custom_emojis", MastodonAPIController, :custom_emojis) | |||
get("/timelines/public", MastodonAPIController, :public_timeline) | |||
get("/timelines/tag/:tag", MastodonAPIController, :hashtag_timeline) | |||
get("/timelines/list/:list_id", MastodonAPIController, :list_timeline) | |||
get("/statuses/:id", MastodonAPIController, :get_status) | |||
get("/statuses/:id/context", MastodonAPIController, :get_context) | |||
get("/statuses/:id/card", MastodonAPIController, :status_card) | |||
get("/statuses/:id/favourited_by", MastodonAPIController, :favourited_by) | |||
get("/statuses/:id/reblogged_by", MastodonAPIController, :reblogged_by) | |||
get("/accounts/:id/statuses", MastodonAPIController, :user_statuses) | |||
get("/accounts/:id/followers", MastodonAPIController, :followers) | |||
get("/accounts/:id/following", MastodonAPIController, :following) | |||
get("/accounts/:id", MastodonAPIController, :user) | |||
get("/trends", MastodonAPIController, :empty_array) | |||
get("/search", MastodonAPIController, :search) | |||
scope [] do | |||
pipe_through(:oauth_read_or_unauthenticated) | |||
get("/timelines/public", MastodonAPIController, :public_timeline) | |||
get("/timelines/tag/:tag", MastodonAPIController, :hashtag_timeline) | |||
get("/timelines/list/:list_id", MastodonAPIController, :list_timeline) | |||
get("/statuses/:id", MastodonAPIController, :get_status) | |||
get("/statuses/:id/context", MastodonAPIController, :get_context) | |||
get("/accounts/:id/statuses", MastodonAPIController, :user_statuses) | |||
get("/accounts/:id/followers", MastodonAPIController, :followers) | |||
get("/accounts/:id/following", MastodonAPIController, :following) | |||
get("/accounts/:id", MastodonAPIController, :user) | |||
get("/search", MastodonAPIController, :search) | |||
end | |||
end | |||
scope "/api/v2", Pleroma.Web.MastodonAPI do | |||
pipe_through(:api) | |||
pipe_through([:api, :oauth_read_or_unauthenticated]) | |||
get("/search", MastodonAPIController, :search2) | |||
end | |||
@@ -294,19 +364,11 @@ defmodule Pleroma.Web.Router do | |||
scope "/api", Pleroma.Web do | |||
pipe_through(:api) | |||
get("/statuses/user_timeline", TwitterAPI.Controller, :user_timeline) | |||
get("/qvitter/statuses/user_timeline", TwitterAPI.Controller, :user_timeline) | |||
get("/users/show", TwitterAPI.Controller, :show_user) | |||
get("/statuses/followers", TwitterAPI.Controller, :followers) | |||
get("/statuses/friends", TwitterAPI.Controller, :friends) | |||
get("/statuses/blocks", TwitterAPI.Controller, :blocks) | |||
get("/statuses/show/:id", TwitterAPI.Controller, :fetch_status) | |||
get("/statusnet/conversation/:id", TwitterAPI.Controller, :fetch_conversation) | |||
post("/account/register", TwitterAPI.Controller, :register) | |||
post("/account/password_reset", TwitterAPI.Controller, :password_reset) | |||
post("/account/resend_confirmation_email", TwitterAPI.Controller, :resend_confirmation_email) | |||
get( | |||
"/account/confirm_email/:user_id/:token", | |||
TwitterAPI.Controller, | |||
@@ -314,14 +376,26 @@ defmodule Pleroma.Web.Router do | |||
as: :confirm_email | |||
) | |||
post("/account/resend_confirmation_email", TwitterAPI.Controller, :resend_confirmation_email) | |||
scope [] do | |||
pipe_through(:oauth_read_or_unauthenticated) | |||
get("/statuses/user_timeline", TwitterAPI.Controller, :user_timeline) | |||
get("/qvitter/statuses/user_timeline", TwitterAPI.Controller, :user_timeline) | |||
get("/users/show", TwitterAPI.Controller, :show_user) | |||
get("/statuses/followers", TwitterAPI.Controller, :followers) | |||
get("/statuses/friends", TwitterAPI.Controller, :friends) | |||
get("/statuses/blocks", TwitterAPI.Controller, :blocks) | |||
get("/statuses/show/:id", TwitterAPI.Controller, :fetch_status) | |||
get("/statusnet/conversation/:id", TwitterAPI.Controller, :fetch_conversation) | |||
get("/search", TwitterAPI.Controller, :search) | |||
get("/statusnet/tags/timeline/:tag", TwitterAPI.Controller, :public_and_external_timeline) | |||
get("/search", TwitterAPI.Controller, :search) | |||
get("/statusnet/tags/timeline/:tag", TwitterAPI.Controller, :public_and_external_timeline) | |||
end | |||
end | |||
scope "/api", Pleroma.Web do | |||
pipe_through(:api) | |||
pipe_through([:api, :oauth_read_or_unauthenticated]) | |||
get("/statuses/public_timeline", TwitterAPI.Controller, :public_timeline) | |||
@@ -335,68 +409,80 @@ defmodule Pleroma.Web.Router do | |||
end | |||
scope "/api", Pleroma.Web, as: :twitter_api_search do | |||
pipe_through(:api) | |||
pipe_through([:api, :oauth_read_or_unauthenticated]) | |||
get("/pleroma/search_user", TwitterAPI.Controller, :search_user) | |||
end | |||
scope "/api", Pleroma.Web, as: :authenticated_twitter_api do | |||
pipe_through(:authenticated_api) | |||
get("/account/verify_credentials", TwitterAPI.Controller, :verify_credentials) | |||
post("/account/verify_credentials", TwitterAPI.Controller, :verify_credentials) | |||
get("/oauth_tokens", TwitterAPI.Controller, :oauth_tokens) | |||
delete("/oauth_tokens/:id", TwitterAPI.Controller, :revoke_token) | |||
post("/account/update_profile", TwitterAPI.Controller, :update_profile) | |||
post("/account/update_profile_banner", TwitterAPI.Controller, :update_banner) | |||
post("/qvitter/update_background_image", TwitterAPI.Controller, :update_background) | |||
scope [] do | |||
pipe_through(:oauth_read) | |||
get("/statuses/home_timeline", TwitterAPI.Controller, :friends_timeline) | |||
get("/statuses/friends_timeline", TwitterAPI.Controller, :friends_timeline) | |||
get("/statuses/mentions", TwitterAPI.Controller, :mentions_timeline) | |||
get("/statuses/mentions_timeline", TwitterAPI.Controller, :mentions_timeline) | |||
get("/statuses/dm_timeline", TwitterAPI.Controller, :dm_timeline) | |||
get("/qvitter/statuses/notifications", TwitterAPI.Controller, :notifications) | |||
get("/account/verify_credentials", TwitterAPI.Controller, :verify_credentials) | |||
post("/account/verify_credentials", TwitterAPI.Controller, :verify_credentials) | |||
# XXX: this is really a pleroma API, but we want to keep the pleroma namespace clean | |||
# for now. | |||
post("/qvitter/statuses/notifications/read", TwitterAPI.Controller, :notifications_read) | |||
get("/statuses/home_timeline", TwitterAPI.Controller, :friends_timeline) | |||
get("/statuses/friends_timeline", TwitterAPI.Controller, :friends_timeline) | |||
get("/statuses/mentions", TwitterAPI.Controller, :mentions_timeline) | |||
get("/statuses/mentions_timeline", TwitterAPI.Controller, :mentions_timeline) | |||
get("/statuses/dm_timeline", TwitterAPI.Controller, :dm_timeline) | |||
get("/qvitter/statuses/notifications", TwitterAPI.Controller, :notifications) | |||
post("/statuses/update", TwitterAPI.Controller, :status_update) | |||
post("/statuses/retweet/:id", TwitterAPI.Controller, :retweet) | |||
post("/statuses/unretweet/:id", TwitterAPI.Controller, :unretweet) | |||
post("/statuses/destroy/:id", TwitterAPI.Controller, :delete_post) | |||
get("/pleroma/friend_requests", TwitterAPI.Controller, :friend_requests) | |||
post("/statuses/pin/:id", TwitterAPI.Controller, :pin) | |||
post("/statuses/unpin/:id", TwitterAPI.Controller, :unpin) | |||
get("/friends/ids", TwitterAPI.Controller, :friends_ids) | |||
get("/friendships/no_retweets/ids", TwitterAPI.Controller, :empty_array) | |||
get("/pleroma/friend_requests", TwitterAPI.Controller, :friend_requests) | |||
post("/pleroma/friendships/approve", TwitterAPI.Controller, :approve_friend_request) | |||
post("/pleroma/friendships/deny", TwitterAPI.Controller, :deny_friend_request) | |||
get("/mutes/users/ids", TwitterAPI.Controller, :empty_array) | |||
get("/qvitter/mutes", TwitterAPI.Controller, :raw_empty_array) | |||
post("/friendships/create", TwitterAPI.Controller, :follow) | |||
post("/friendships/destroy", TwitterAPI.Controller, :unfollow) | |||
post("/blocks/create", TwitterAPI.Controller, :block) | |||
post("/blocks/destroy", TwitterAPI.Controller, :unblock) | |||
get("/externalprofile/show", TwitterAPI.Controller, :external_profile) | |||
post("/statusnet/media/upload", TwitterAPI.Controller, :upload) | |||
post("/media/upload", TwitterAPI.Controller, :upload_json) | |||
post("/media/metadata/create", TwitterAPI.Controller, :update_media) | |||
post("/qvitter/statuses/notifications/read", TwitterAPI.Controller, :notifications_read) | |||
end | |||
post("/favorites/create/:id", TwitterAPI.Controller, :favorite) | |||
post("/favorites/create", TwitterAPI.Controller, :favorite) | |||
post("/favorites/destroy/:id", TwitterAPI.Controller, :unfavorite) | |||
scope [] do | |||
pipe_through(:oauth_write) | |||
post("/qvitter/update_avatar", TwitterAPI.Controller, :update_avatar) | |||
post("/account/update_profile", TwitterAPI.Controller, :update_profile) | |||
post("/account/update_profile_banner", TwitterAPI.Controller, :update_banner) | |||
post("/qvitter/update_background_image", TwitterAPI.Controller, :update_background) | |||
get("/friends/ids", TwitterAPI.Controller, :friends_ids) | |||
get("/friendships/no_retweets/ids", TwitterAPI.Controller, :empty_array) | |||
post("/statuses/update", TwitterAPI.Controller, :status_update) | |||
post("/statuses/retweet/:id", TwitterAPI.Controller, :retweet) | |||
post("/statuses/unretweet/:id", TwitterAPI.Controller, :unretweet) | |||
post("/statuses/destroy/:id", TwitterAPI.Controller, :delete_post) | |||
get("/mutes/users/ids", TwitterAPI.Controller, :empty_array) | |||
get("/qvitter/mutes", TwitterAPI.Controller, :raw_empty_array) | |||
post("/statuses/pin/:id", TwitterAPI.Controller, :pin) | |||
post("/statuses/unpin/:id", TwitterAPI.Controller, :unpin) | |||
get("/externalprofile/show", TwitterAPI.Controller, :external_profile) | |||
post("/statusnet/media/upload", TwitterAPI.Controller, :upload) | |||
post("/media/upload", TwitterAPI.Controller, :upload_json) | |||
post("/media/metadata/create", TwitterAPI.Controller, :update_media) | |||
get("/oauth_tokens", TwitterAPI.Controller, :oauth_tokens) | |||
delete("/oauth_tokens/:id", TwitterAPI.Controller, :revoke_token) | |||
post("/favorites/create/:id", TwitterAPI.Controller, :favorite) | |||
post("/favorites/create", TwitterAPI.Controller, :favorite) | |||
post("/favorites/destroy/:id", TwitterAPI.Controller, :unfavorite) | |||
post("/qvitter/update_avatar", TwitterAPI.Controller, :update_avatar) | |||
end | |||
scope [] do | |||
pipe_through(:oauth_follow) | |||
post("/pleroma/friendships/approve", TwitterAPI.Controller, :approve_friend_request) | |||
post("/pleroma/friendships/deny", TwitterAPI.Controller, :deny_friend_request) | |||
post("/friendships/create", TwitterAPI.Controller, :follow) | |||
post("/friendships/destroy", TwitterAPI.Controller, :unfollow) | |||
post("/blocks/create", TwitterAPI.Controller, :block) | |||
post("/blocks/destroy", TwitterAPI.Controller, :unblock) | |||
end | |||
end | |||
pipeline :ap_relay do | |||
@@ -464,9 +550,16 @@ defmodule Pleroma.Web.Router do | |||
scope "/", Pleroma.Web.ActivityPub do | |||
pipe_through([:activitypub_client]) | |||
get("/api/ap/whoami", ActivityPubController, :whoami) | |||
get("/users/:nickname/inbox", ActivityPubController, :read_inbox) | |||
post("/users/:nickname/outbox", ActivityPubController, :update_outbox) | |||
scope [] do | |||
pipe_through(:oauth_read) | |||
get("/api/ap/whoami", ActivityPubController, :whoami) | |||
get("/users/:nickname/inbox", ActivityPubController, :read_inbox) | |||
end | |||
scope [] do | |||
pipe_through(:oauth_write) | |||
post("/users/:nickname/outbox", ActivityPubController, :update_outbox) | |||
end | |||
end | |||
scope "/relay", Pleroma.Web.ActivityPub do | |||
@@ -496,9 +589,12 @@ defmodule Pleroma.Web.Router do | |||
pipe_through(:mastodon_html) | |||
get("/web/login", MastodonAPIController, :login) | |||
post("/web/login", MastodonAPIController, :login_post) | |||
get("/web/*path", MastodonAPIController, :index) | |||
delete("/auth/sign_out", MastodonAPIController, :logout) | |||
scope [] do | |||
pipe_through(:oauth_read_or_unauthenticated) | |||
get("/web/*path", MastodonAPIController, :index) | |||
end | |||
end | |||
pipeline :remote_media do | |||
@@ -506,6 +602,7 @@ defmodule Pleroma.Web.Router do | |||
scope "/proxy/", Pleroma.Web.MediaProxy do | |||
pipe_through(:remote_media) | |||
get("/:sig/:url", MediaProxyController, :remote) | |||
get("/:sig/:url/:filename", MediaProxyController, :remote) | |||
end | |||
@@ -54,6 +54,10 @@ | |||
border-bottom: 2px solid #4b8ed8; | |||
} | |||
input[type="checkbox"] { | |||
width: auto; | |||
} | |||
button { | |||
box-sizing: border-box; | |||
width: 100%; | |||
@@ -9,13 +9,24 @@ | |||
<%= label f, :name, "Name or email" %> | |||
<%= text_input f, :name %> | |||
<br> | |||
<br> | |||
<%= label f, :password, "Password" %> | |||
<%= password_input f, :password %> | |||
<br> | |||
<br> | |||
<%= label f, :scope, "Permissions" %> | |||
<br> | |||
<%= for scope <- @available_scopes do %> | |||
<%# Note: using hidden input with `unchecked_value` in order to distinguish user's empty selection from `scope` param being omitted %> | |||
<%= checkbox f, :"scope_#{scope}", value: scope in @scopes && scope, checked_value: scope, unchecked_value: "", name: "authorization[scope][]" %> | |||
<%= label f, :"scope_#{scope}", String.capitalize(scope) %> | |||
<br> | |||
<% end %> | |||
<%= hidden_input f, :client_id, value: @client_id %> | |||
<%= hidden_input f, :response_type, value: @response_type %> | |||
<%= hidden_input f, :redirect_uri, value: @redirect_uri %> | |||
<%= hidden_input f, :scope, value: @scope %> | |||
<%= hidden_input f, :state, value: @state%> | |||
<%= submit "Authorize" %> | |||
<% end %> |
@@ -20,8 +20,8 @@ | |||
"ex_aws_s3": {:hex, :ex_aws_s3, "2.0.1", "9e09366e77f25d3d88c5393824e613344631be8db0d1839faca49686e99b6704", [:mix], [{:ex_aws, "~> 2.0", [hex: :ex_aws, repo: "hexpm", optional: false]}, {:sweet_xml, ">= 0.0.0", [hex: :sweet_xml, repo: "hexpm", optional: true]}], "hexpm"}, | |||
"ex_doc": {:hex, :ex_doc, "0.19.1", "519bb9c19526ca51d326c060cb1778d4a9056b190086a8c6c115828eaccea6cf", [:mix], [{:earmark, "~> 1.1", [hex: :earmark, repo: "hexpm", optional: false]}, {:makeup_elixir, "~> 0.7", [hex: :makeup_elixir, repo: "hexpm", optional: false]}], "hexpm"}, | |||
"ex_machina": {:hex, :ex_machina, "2.2.0", "fec496331e04fc2db2a1a24fe317c12c0c4a50d2beb8ebb3531ed1f0d84be0ed", [:mix], [{:ecto, "~> 2.1", [hex: :ecto, repo: "hexpm", optional: true]}], "hexpm"}, | |||
"floki": {:hex, :floki, "0.20.4", "be42ac911fece24b4c72f3b5846774b6e61b83fe685c2fc9d62093277fb3bc86", [:mix], [{:html_entities, "~> 0.4.0", [hex: :html_entities, repo: "hexpm", optional: false]}, {:mochiweb, "~> 2.15", [hex: :mochiweb, repo: "hexpm", optional: false]}], "hexpm"}, | |||
"ex_syslogger": {:git, "https://github.com/slashmili/ex_syslogger.git", "f3963399047af17e038897c69e20d552e6899e1d", [tag: "1.4.0"]}, | |||
"floki": {:hex, :floki, "0.20.4", "be42ac911fece24b4c72f3b5846774b6e61b83fe685c2fc9d62093277fb3bc86", [:mix], [{:html_entities, "~> 0.4.0", [hex: :html_entities, repo: "hexpm", optional: false]}, {:mochiweb, "~> 2.15", [hex: :mochiweb, repo: "hexpm", optional: false]}], "hexpm"}, | |||
"gen_smtp": {:hex, :gen_smtp, "0.13.0", "11f08504c4bdd831dc520b8f84a1dce5ce624474a797394e7aafd3c29f5dcd25", [:rebar3], [], "hexpm"}, | |||
"gettext": {:hex, :gettext, "0.15.0", "40a2b8ce33a80ced7727e36768499fc9286881c43ebafccae6bab731e2b2b8ce", [:mix], [], "hexpm"}, | |||
"hackney": {:hex, :hackney, "1.14.3", "b5f6f5dcc4f1fba340762738759209e21914516df6be440d85772542d4a5e412", [:rebar3], [{:certifi, "2.4.2", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "6.0.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "1.0.1", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "1.0.2", [hex: :mimerl, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "1.1.4", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}], "hexpm"}, | |||
@@ -45,9 +45,9 @@ | |||
"pbkdf2_elixir": {:hex, :pbkdf2_elixir, "0.12.3", "6706a148809a29c306062862c803406e88f048277f6e85b68faf73291e820b84", [:mix], [], "hexpm"}, | |||
"phoenix": {:git, "https://github.com/phoenixframework/phoenix.git", "ea22dc50b574178a300ecd19253443960407df93", [branch: "v1.4"]}, | |||
"phoenix_ecto": {:hex, :phoenix_ecto, "3.3.0", "702f6e164512853d29f9d20763493f2b3bcfcb44f118af2bc37bb95d0801b480", [:mix], [{:ecto, "~> 2.1", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.9", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.0", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm"}, | |||
"phoenix_html": {:hex, :phoenix_html, "2.11.2", "86ebd768258ba60a27f5578bec83095bdb93485d646fc4111db8844c316602d6", [:mix], [{:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm"}, | |||
"phoenix_html": {:hex, :phoenix_html, "2.13.1", "fa8f034b5328e2dfa0e4131b5569379003f34bc1fafdaa84985b0b9d2f12e68b", [:mix], [{:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm"}, | |||
"phoenix_pubsub": {:hex, :phoenix_pubsub, "1.1.1", "6668d787e602981f24f17a5fbb69cc98f8ab085114ebfac6cc36e10a90c8e93c", [:mix], [], "hexpm"}, | |||
"plug": {:hex, :plug, "1.7.1", "8516d565fb84a6a8b2ca722e74e2cd25ca0fc9d64f364ec9dbec09d33eb78ccd", [:mix], [{:mime, "~> 1.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}], "hexpm"}, | |||
"plug": {:hex, :plug, "1.7.2", "d7b7db7fbd755e8283b6c0a50be71ec0a3d67d9213d74422d9372effc8e87fd1", [:mix], [{:mime, "~> 1.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}], "hexpm"}, | |||
"plug_cowboy": {:hex, :plug_cowboy, "1.0.0", "2e2a7d3409746d335f451218b8bb0858301c3de6d668c3052716c909936eb57a", [:mix], [{:cowboy, "~> 1.0", [hex: :cowboy, repo: "hexpm", optional: false]}, {:plug, "~> 1.7", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm"}, | |||
"plug_crypto": {:hex, :plug_crypto, "1.0.0", "18e49317d3fa343f24620ed22795ec29d4a5e602d52d1513ccea0b07d8ea7d4d", [:mix], [], "hexpm"}, | |||
"poison": {:hex, :poison, "3.1.0", "d9eb636610e096f86f25d9a46f35a9facac35609a7591b3be3326e99a0484665", [:mix], [], "hexpm"}, | |||
@@ -0,0 +1,11 @@ | |||
defmodule Pleroma.Repo.Migrations.AddScopeSToOAuthEntities do | |||
use Ecto.Migration | |||
def change do | |||
for t <- [:oauth_authorizations, :oauth_tokens] do | |||
alter table(t) do | |||
add :scopes, {:array, :string}, default: [], null: false | |||
end | |||
end | |||
end | |||
end |
@@ -0,0 +1,17 @@ | |||
defmodule Pleroma.Repo.Migrations.ChangeAppsScopesToVarcharArray do | |||
use Ecto.Migration | |||
@alter_apps_scopes "ALTER TABLE apps ALTER COLUMN scopes" | |||
def up do | |||
execute "#{@alter_apps_scopes} TYPE varchar(255)[] USING string_to_array(scopes, ',')::varchar(255)[];" | |||
execute "#{@alter_apps_scopes} SET DEFAULT ARRAY[]::character varying[];" | |||
execute "#{@alter_apps_scopes} SET NOT NULL;" | |||
end | |||
def down do | |||
execute "#{@alter_apps_scopes} DROP NOT NULL;" | |||
execute "#{@alter_apps_scopes} DROP DEFAULT;" | |||
execute "#{@alter_apps_scopes} TYPE varchar(255) USING array_to_string(scopes, ',')::varchar(255);" | |||
end | |||
end |
@@ -0,0 +1,11 @@ | |||
defmodule Pleroma.Repo.Migrations.DataMigrationPopulateOAuthScopes do | |||
use Ecto.Migration | |||
def up do | |||
for t <- [:oauth_authorizations, :oauth_tokens] do | |||
execute "UPDATE #{t} SET scopes = apps.scopes FROM apps WHERE #{t}.app_id = apps.id;" | |||
end | |||
end | |||
def down, do: :noop | |||
end |
@@ -80,7 +80,7 @@ defmodule Pleroma.Integration.MastodonWebsocketTest do | |||
Pleroma.Repo.insert( | |||
OAuth.App.register_changeset(%OAuth.App{}, %{ | |||
client_name: "client", | |||
scopes: "scope", | |||
scopes: ["scope"], | |||
redirect_uris: "url" | |||
}) | |||
) | |||
@@ -0,0 +1,122 @@ | |||
# Pleroma: A lightweight social networking server | |||
# Copyright © 2017-2018 Pleroma Authors <https://pleroma.social/> | |||
# SPDX-License-Identifier: AGPL-3.0-only | |||
defmodule Pleroma.Plugs.OAuthScopesPlugTest do | |||
use Pleroma.Web.ConnCase, async: true | |||
alias Pleroma.Plugs.OAuthScopesPlug | |||
alias Pleroma.Repo | |||
import Pleroma.Factory | |||
test "proceeds with no op if `assigns[:token]` is nil", %{conn: conn} do | |||
conn = | |||
conn | |||
|> assign(:user, insert(:user)) | |||
|> OAuthScopesPlug.call(%{scopes: ["read"]}) | |||
refute conn.halted | |||
assert conn.assigns[:user] | |||
end | |||
test "proceeds with no op if `token.scopes` fulfill specified 'any of' conditions", %{ | |||
conn: conn | |||
} do | |||
token = insert(:oauth_token, scopes: ["read", "write"]) |> Repo.preload(:user) | |||
conn = | |||
conn | |||
|> assign(:user, token.user) | |||
|> assign(:token, token) | |||
|> OAuthScopesPlug.call(%{scopes: ["read"]}) | |||
refute conn.halted | |||
assert conn.assigns[:user] | |||
end | |||
test "proceeds with no op if `token.scopes` fulfill specified 'all of' conditions", %{ | |||
conn: conn | |||
} do | |||
token = insert(:oauth_token, scopes: ["scope1", "scope2", "scope3"]) |> Repo.preload(:user) | |||
conn = | |||
conn | |||
|> assign(:user, token.user) | |||
|> assign(:token, token) | |||
|> OAuthScopesPlug.call(%{scopes: ["scope2", "scope3"], op: :&}) | |||
refute conn.halted | |||
assert conn.assigns[:user] | |||
end | |||
test "proceeds with cleared `assigns[:user]` if `token.scopes` doesn't fulfill specified 'any of' conditions " <> | |||
"and `fallback: :proceed_unauthenticated` option is specified", | |||
%{conn: conn} do | |||
token = insert(:oauth_token, scopes: ["read", "write"]) |> Repo.preload(:user) | |||
conn = | |||
conn | |||
|> assign(:user, token.user) | |||
|> assign(:token, token) | |||
|> OAuthScopesPlug.call(%{scopes: ["follow"], fallback: :proceed_unauthenticated}) | |||
refute conn.halted | |||
refute conn.assigns[:user] | |||
end | |||
test "proceeds with cleared `assigns[:user]` if `token.scopes` doesn't fulfill specified 'all of' conditions " <> | |||
"and `fallback: :proceed_unauthenticated` option is specified", | |||
%{conn: conn} do | |||
token = insert(:oauth_token, scopes: ["read", "write"]) |> Repo.preload(:user) | |||
conn = | |||
conn | |||
|> assign(:user, token.user) | |||
|> assign(:token, token) | |||
|> OAuthScopesPlug.call(%{ | |||
scopes: ["read", "follow"], | |||
op: :&, | |||
fallback: :proceed_unauthenticated | |||
}) | |||
refute conn.halted | |||
refute conn.assigns[:user] | |||
end | |||
test "returns 403 and halts in case of no :fallback option and `token.scopes` not fulfilling specified 'any of' conditions", | |||
%{conn: conn} do | |||
token = insert(:oauth_token, scopes: ["read", "write"]) | |||
any_of_scopes = ["follow"] | |||
conn = | |||
conn | |||
|> assign(:token, token) | |||
|> OAuthScopesPlug.call(%{scopes: any_of_scopes}) | |||
assert conn.halted | |||
assert 403 == conn.status | |||
expected_error = "Insufficient permissions: #{Enum.join(any_of_scopes, ", ")}." | |||
assert Jason.encode!(%{error: expected_error}) == conn.resp_body | |||
end | |||
test "returns 403 and halts in case of no :fallback option and `token.scopes` not fulfilling specified 'all of' conditions", | |||
%{conn: conn} do | |||
token = insert(:oauth_token, scopes: ["read", "write"]) | |||
all_of_scopes = ["write", "follow"] | |||
conn = | |||
conn | |||
|> assign(:token, token) | |||
|> OAuthScopesPlug.call(%{scopes: all_of_scopes, op: :&}) | |||
assert conn.halted | |||
assert 403 == conn.status | |||
expected_error = | |||
"Insufficient permissions: #{Enum.join(all_of_scopes -- token.scopes, ", ")}." | |||
assert Jason.encode!(%{error: expected_error}) == conn.resp_body | |||
end | |||
end |
@@ -214,7 +214,7 @@ defmodule Pleroma.Factory do | |||
%Pleroma.Web.OAuth.App{ | |||
client_name: "Some client", | |||
redirect_uris: "https://example.com/callback", | |||
scopes: "read", | |||
scopes: ["read", "write", "follow", "push"], | |||
website: "https://example.com", | |||
client_id: "aaabbb==", | |||
client_secret: "aaa;/&bbb" | |||
@@ -1556,6 +1556,24 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIControllerTest do | |||
assert user_response = json_response(conn, 200) | |||
assert user_response["header"] != User.banner_url(user) | |||
end | |||
test "requires 'write' permission", %{conn: conn} do | |||
token1 = insert(:oauth_token, scopes: ["read"]) | |||
token2 = insert(:oauth_token, scopes: ["write", "follow"]) | |||
for token <- [token1, token2] do | |||
conn = | |||
conn | |||
|> put_req_header("authorization", "Bearer #{token.token}") | |||
|> patch("/api/v1/accounts/update_credentials", %{}) | |||
if token == token1 do | |||
assert %{"error" => "Insufficient permissions: write."} == json_response(conn, 403) | |||
else | |||
assert json_response(conn, 200) | |||
end | |||
end | |||
end | |||
end | |||
test "get instance information", %{conn: conn} do | |||
@@ -8,36 +8,37 @@ defmodule Pleroma.Web.OAuth.AuthorizationTest do | |||
alias Pleroma.Web.OAuth.App | |||
import Pleroma.Factory | |||
test "create an authorization token for a valid app" do | |||
setup do | |||
{:ok, app} = | |||
Repo.insert( | |||
App.register_changeset(%App{}, %{ | |||
client_name: "client", | |||
scopes: "scope", | |||
scopes: ["read", "write"], | |||
redirect_uris: "url" | |||
}) | |||
) | |||
%{app: app} | |||
end | |||
test "create an authorization token for a valid app", %{app: app} do | |||
user = insert(:user) | |||
{:ok, auth} = Authorization.create_authorization(app, user) | |||
{:ok, auth1} = Authorization.create_authorization(app, user) | |||
assert auth1.scopes == app.scopes | |||
assert auth.user_id == user.id | |||
assert auth.app_id == app.id | |||
assert String.length(auth.token) > 10 | |||
assert auth.used == false | |||
end | |||
{:ok, auth2} = Authorization.create_authorization(app, user, ["read"]) | |||
assert auth2.scopes == ["read"] | |||
test "use up a token" do | |||
{:ok, app} = | |||
Repo.insert( | |||
App.register_changeset(%App{}, %{ | |||
client_name: "client", | |||
scopes: "scope", | |||
redirect_uris: "url" | |||
}) | |||
) | |||
for auth <- [auth1, auth2] do | |||
assert auth.user_id == user.id | |||
assert auth.app_id == app.id | |||
assert String.length(auth.token) > 10 | |||
assert auth.used == false | |||
end | |||
end | |||
test "use up a token", %{app: app} do | |||
user = insert(:user) | |||
{:ok, auth} = Authorization.create_authorization(app, user) | |||
@@ -61,16 +62,7 @@ defmodule Pleroma.Web.OAuth.AuthorizationTest do | |||
assert {:error, "token expired"} == Authorization.use_token(expired_auth) | |||
end | |||
test "delete authorizations" do | |||
{:ok, app} = | |||
Repo.insert( | |||
App.register_changeset(%App{}, %{ | |||
client_name: "client", | |||
scopes: "scope", | |||
redirect_uris: "url" | |||
}) | |||
) | |||
test "delete authorizations", %{app: app} do | |||
user = insert(:user) | |||
{:ok, auth} = Authorization.create_authorization(app, user) | |||
@@ -12,7 +12,7 @@ defmodule Pleroma.Web.OAuth.OAuthControllerTest do | |||
test "redirects with oauth authorization" do | |||
user = insert(:user) | |||
app = insert(:oauth_app) | |||
app = insert(:oauth_app, scopes: ["read", "write", "follow"]) | |||
conn = | |||
build_conn() | |||
@@ -22,6 +22,7 @@ defmodule Pleroma.Web.OAuth.OAuthControllerTest do | |||
"password" => "test", | |||
"client_id" => app.client_id, | |||
"redirect_uri" => app.redirect_uris, | |||
"scope" => "read write", | |||
"state" => "statepassed" | |||
} | |||
}) | |||
@@ -32,10 +33,12 @@ defmodule Pleroma.Web.OAuth.OAuthControllerTest do | |||
query = URI.parse(target).query |> URI.query_decoder() |> Map.new() | |||
assert %{"state" => "statepassed", "code" => code} = query | |||
assert Repo.get_by(Authorization, token: code) | |||
auth = Repo.get_by(Authorization, token: code) | |||
assert auth | |||
assert auth.scopes == ["read", "write"] | |||
end | |||
test "correctly handles wrong credentials", %{conn: conn} do | |||
test "returns 401 for wrong credentials", %{conn: conn} do | |||
user = insert(:user) | |||
app = insert(:oauth_app) | |||
@@ -47,7 +50,8 @@ defmodule Pleroma.Web.OAuth.OAuthControllerTest do | |||
"password" => "wrong", | |||
"client_id" => app.client_id, | |||
"redirect_uri" => app.redirect_uris, | |||
"state" => "statepassed" | |||
"state" => "statepassed", | |||
"scope" => Enum.join(app.scopes, " ") | |||
} | |||
}) | |||
|> html_response(:unauthorized) | |||
@@ -57,14 +61,66 @@ defmodule Pleroma.Web.OAuth.OAuthControllerTest do | |||
assert result =~ app.redirect_uris | |||
# Error message | |||
assert result =~ "Invalid" | |||
assert result =~ "Invalid Username/Password" | |||
end | |||
test "issues a token for an all-body request" do | |||
test "returns 401 for missing scopes", %{conn: conn} do | |||
user = insert(:user) | |||
app = insert(:oauth_app) | |||
{:ok, auth} = Authorization.create_authorization(app, user) | |||
result = | |||
conn | |||
|> post("/oauth/authorize", %{ | |||
"authorization" => %{ | |||
"name" => user.nickname, | |||
"password" => "test", | |||
"client_id" => app.client_id, | |||
"redirect_uri" => app.redirect_uris, | |||
"state" => "statepassed", | |||
"scope" => "" | |||
} | |||
}) | |||
|> html_response(:unauthorized) | |||
# Keep the details | |||
assert result =~ app.client_id | |||
assert result =~ app.redirect_uris | |||
# Error message | |||
assert result =~ "Permissions not specified" | |||
end | |||
test "returns 401 for scopes beyond app scopes", %{conn: conn} do | |||
user = insert(:user) | |||
app = insert(:oauth_app, scopes: ["read", "write"]) | |||
result = | |||
conn | |||
|> post("/oauth/authorize", %{ | |||
"authorization" => %{ | |||
"name" => user.nickname, | |||
"password" => "test", | |||
"client_id" => app.client_id, | |||
"redirect_uri" => app.redirect_uris, | |||
"state" => "statepassed", | |||
"scope" => "read write follow" | |||
} | |||
}) | |||
|> html_response(:unauthorized) | |||
# Keep the details | |||
assert result =~ app.client_id | |||
assert result =~ app.redirect_uris | |||
# Error message | |||
assert result =~ "Permissions not specified" | |||
end | |||
test "issues a token for an all-body request" do | |||
user = insert(:user) | |||
app = insert(:oauth_app, scopes: ["read", "write"]) | |||
{:ok, auth} = Authorization.create_authorization(app, user, ["write"]) | |||
conn = | |||
build_conn() | |||
@@ -77,15 +133,19 @@ defmodule Pleroma.Web.OAuth.OAuthControllerTest do | |||
}) | |||
assert %{"access_token" => token} = json_response(conn, 200) | |||
assert Repo.get_by(Token, token: token) | |||
token = Repo.get_by(Token, token: token) | |||
assert token | |||
assert token.scopes == auth.scopes | |||
end | |||
test "issues a token for `password` grant_type with valid credentials" do | |||
test "issues a token for `password` grant_type with valid credentials, with full permissions by default" do | |||
password = "testpassword" | |||
user = insert(:user, password_hash: Comeonin.Pbkdf2.hashpwsalt(password)) | |||
app = insert(:oauth_app) | |||
app = insert(:oauth_app, scopes: ["read", "write"]) | |||
# Note: "scope" param is intentionally omitted | |||
conn = | |||
build_conn() | |||
|> post("/oauth/token", %{ | |||
@@ -97,14 +157,18 @@ defmodule Pleroma.Web.OAuth.OAuthControllerTest do | |||
}) | |||
assert %{"access_token" => token} = json_response(conn, 200) | |||
assert Repo.get_by(Token, token: token) | |||
token = Repo.get_by(Token, token: token) | |||
assert token | |||
assert token.scopes == app.scopes | |||
end | |||
test "issues a token for request with HTTP basic auth client credentials" do | |||
user = insert(:user) | |||
app = insert(:oauth_app) | |||
app = insert(:oauth_app, scopes: ["scope1", "scope2"]) | |||
{:ok, auth} = Authorization.create_authorization(app, user) | |||
{:ok, auth} = Authorization.create_authorization(app, user, ["scope2"]) | |||
assert auth.scopes == ["scope2"] | |||
app_encoded = | |||
(URI.encode_www_form(app.client_id) <> ":" <> URI.encode_www_form(app.client_secret)) | |||
@@ -120,7 +184,10 @@ defmodule Pleroma.Web.OAuth.OAuthControllerTest do | |||
}) | |||
assert %{"access_token" => token} = json_response(conn, 200) | |||
assert Repo.get_by(Token, token: token) | |||
token = Repo.get_by(Token, token: token) | |||
assert token | |||
assert token.scopes == ["scope2"] | |||
end | |||
test "rejects token exchange with invalid client credentials" do | |||
@@ -11,24 +11,26 @@ defmodule Pleroma.Web.OAuth.TokenTest do | |||
import Pleroma.Factory | |||
test "exchanges a auth token for an access token" do | |||
test "exchanges a auth token for an access token, preserving `scopes`" do | |||
{:ok, app} = | |||
Repo.insert( | |||
App.register_changeset(%App{}, %{ | |||
client_name: "client", | |||
scopes: "scope", | |||
scopes: ["read", "write"], | |||
redirect_uris: "url" | |||
}) | |||
) | |||
user = insert(:user) | |||
{:ok, auth} = Authorization.create_authorization(app, user) | |||
{:ok, auth} = Authorization.create_authorization(app, user, ["read"]) | |||
assert auth.scopes == ["read"] | |||
{:ok, token} = Token.exchange_token(app, auth) | |||
assert token.app_id == app.id | |||
assert token.user_id == user.id | |||
assert token.scopes == auth.scopes | |||
assert String.length(token.token) > 10 | |||
assert String.length(token.refresh_token) > 10 | |||
@@ -41,7 +43,7 @@ defmodule Pleroma.Web.OAuth.TokenTest do | |||
Repo.insert( | |||
App.register_changeset(%App{}, %{ | |||
client_name: "client1", | |||
scopes: "scope", | |||
scopes: ["scope"], | |||
redirect_uris: "url" | |||
}) | |||
) | |||
@@ -50,7 +52,7 @@ defmodule Pleroma.Web.OAuth.TokenTest do | |||
Repo.insert( | |||
App.register_changeset(%App{}, %{ | |||
client_name: "client2", | |||
scopes: "scope", | |||
scopes: ["scope"], | |||
redirect_uris: "url" | |||
}) | |||
) | |||
@@ -14,6 +14,7 @@ defmodule Pleroma.Web.TwitterAPI.ControllerTest do | |||
alias Pleroma.Notification | |||
alias Pleroma.Web.ActivityPub.ActivityPub | |||
alias Pleroma.Web.OAuth.Token | |||
alias Pleroma.Web.TwitterAPI.Controller | |||
alias Pleroma.Web.TwitterAPI.UserView | |||
alias Pleroma.Web.TwitterAPI.NotificationView | |||
alias Pleroma.Web.CommonAPI | |||
@@ -22,6 +23,7 @@ defmodule Pleroma.Web.TwitterAPI.ControllerTest do | |||
alias Ecto.Changeset | |||
import Pleroma.Factory | |||
import Mock | |||
@banner "data:image/gif;base64,R0lGODlhEAAQAMQAAORHHOVSKudfOulrSOp3WOyDZu6QdvCchPGolfO0o/XBs/fNwfjZ0frl3/zy7////wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACH5BAkAABAALAAAAAAQABAAAAVVICSOZGlCQAosJ6mu7fiyZeKqNKToQGDsM8hBADgUXoGAiqhSvp5QAnQKGIgUhwFUYLCVDFCrKUE1lBavAViFIDlTImbKC5Gm2hB0SlBCBMQiB0UjIQA7" | |||
@@ -187,6 +189,20 @@ defmodule Pleroma.Web.TwitterAPI.ControllerTest do | |||
|> get("/api/statuses/public_timeline.json") | |||
|> json_response(200) | |||
end | |||
test_with_mock "treats user as unauthenticated if `assigns[:token]` is present but lacks `read` permission", | |||
Controller, | |||
[:passthrough], | |||
[] do | |||
token = insert(:oauth_token, scopes: ["write"]) | |||
build_conn() | |||
|> put_req_header("authorization", "Bearer #{token.token}") | |||
|> get("/api/statuses/public_timeline.json") | |||
|> json_response(200) | |||
assert called(Controller.public_timeline(%{assigns: %{user: nil}}, :_)) | |||
end | |||
end | |||
describe "GET /statuses/public_and_external_timeline.json" do | |||
@@ -1690,6 +1706,24 @@ defmodule Pleroma.Web.TwitterAPI.ControllerTest do | |||
assert [relationship] = json_response(conn, 200) | |||
assert other_user.id == relationship["id"] | |||
end | |||
test "requires 'read' permission", %{conn: conn} do | |||
token1 = insert(:oauth_token, scopes: ["write"]) | |||
token2 = insert(:oauth_token, scopes: ["read"]) | |||
for token <- [token1, token2] do | |||
conn = | |||
conn | |||
|> put_req_header("authorization", "Bearer #{token.token}") | |||
|> get("/api/pleroma/friend_requests") | |||
if token == token1 do | |||
assert %{"error" => "Insufficient permissions: read."} == json_response(conn, 403) | |||
else | |||
assert json_response(conn, 200) | |||
end | |||
end | |||
end | |||
end | |||
describe "POST /api/pleroma/friendships/approve" do | |||
@@ -16,6 +16,25 @@ defmodule Pleroma.Web.TwitterAPI.UtilControllerTest do | |||
assert response == "job started" | |||
end | |||
test "requires 'follow' permission", %{conn: conn} do | |||
token1 = insert(:oauth_token, scopes: ["read", "write"]) | |||
token2 = insert(:oauth_token, scopes: ["follow"]) | |||
another_user = insert(:user) | |||
for token <- [token1, token2] do | |||
conn = | |||
conn | |||
|> put_req_header("authorization", "Bearer #{token.token}") | |||
|> post("/api/pleroma/follow_import", %{"list" => "#{another_user.ap_id}"}) | |||
if token == token1 do | |||
assert %{"error" => "Insufficient permissions: follow."} == json_response(conn, 403) | |||
else | |||
assert json_response(conn, 200) | |||
end | |||
end | |||
end | |||
end | |||
describe "POST /api/pleroma/blocks_import" do | |||