Browse Source

LegacyAuthenticationPlug module name

1668/default-disable-prometheus
Alexander Strizhakov 4 years ago
parent
commit
e2332d92ce
No known key found for this signature in database GPG Key ID: 22896A53AEF1381
4 changed files with 4 additions and 4 deletions
  1. +1
    -1
      docs/dev.md
  2. +1
    -1
      lib/pleroma/web/plugs/legacy_authentication_plug.ex
  3. +1
    -1
      lib/pleroma/web/router.ex
  4. +1
    -1
      test/pleroma/web/plugs/legacy_authentication_plug_test.exs

+ 1
- 1
docs/dev.md View File

@@ -16,7 +16,7 @@ This document contains notes and guidelines for Pleroma developers.

## [HTTP Basic Authentication](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Authorization)

* With HTTP Basic Auth, OAuth scopes check is _not_ performed for any action (since password is provided during the auth, requester is able to obtain a token with full permissions anyways). `Pleroma.Plugs.AuthenticationPlug` and `Pleroma.Plugs.LegacyAuthenticationPlug` both call `Pleroma.Web.Plugs.OAuthScopesPlug.skip_plug(conn)` when password is provided.
* With HTTP Basic Auth, OAuth scopes check is _not_ performed for any action (since password is provided during the auth, requester is able to obtain a token with full permissions anyways). `Pleroma.Plugs.AuthenticationPlug` and `Pleroma.Web.Plugs.LegacyAuthenticationPlug` both call `Pleroma.Web.Plugs.OAuthScopesPlug.skip_plug(conn)` when password is provided.

## Auth-related configuration, OAuth consumer mode etc.



+ 1
- 1
lib/pleroma/web/plugs/legacy_authentication_plug.ex View File

@@ -2,7 +2,7 @@
# Copyright © 2017-2020 Pleroma Authors <https://pleroma.social/>
# SPDX-License-Identifier: AGPL-3.0-only

defmodule Pleroma.Plugs.LegacyAuthenticationPlug do
defmodule Pleroma.Web.Plugs.LegacyAuthenticationPlug do
import Plug.Conn

alias Pleroma.User


+ 1
- 1
lib/pleroma/web/router.ex View File

@@ -29,7 +29,7 @@ defmodule Pleroma.Web.Router do
plug(Pleroma.Plugs.BasicAuthDecoderPlug)
plug(Pleroma.Web.Plugs.UserFetcherPlug)
plug(Pleroma.Web.Plugs.SessionAuthenticationPlug)
plug(Pleroma.Plugs.LegacyAuthenticationPlug)
plug(Pleroma.Web.Plugs.LegacyAuthenticationPlug)
plug(Pleroma.Plugs.AuthenticationPlug)
end



+ 1
- 1
test/pleroma/web/plugs/legacy_authentication_plug_test.exs View File

@@ -7,7 +7,7 @@ defmodule Pleroma.Web.Plugs.LegacyAuthenticationPlugTest do

import Pleroma.Factory

alias Pleroma.Plugs.LegacyAuthenticationPlug
alias Pleroma.Web.Plugs.LegacyAuthenticationPlug
alias Pleroma.Web.Plugs.OAuthScopesPlug
alias Pleroma.Web.Plugs.PlugHelper
alias Pleroma.User


Loading…
Cancel
Save