Fix broken packaging

gtk-recordmydesktop.spec

@@ -1,26 +1,30 @@
-%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
-
 Name:           gtk-recordmydesktop
 Version:        0.3.8
-Release:        19%{?dist}
+Release:        20%{?dist}
 Summary:        GUI Desktop session recorder with audio and video
 
 License:        GPLv2+
 URL:            http://recordmydesktop.sourceforge.net/
-Source0:        http://dl.sourceforge.net/recordmydesktop/%{name}-%{version}.tar.gz        
+Source0:        http://downloads.sourceforge.net/recordmydesktop/%{name}-%{version}.tar.gz
 
 BuildArch:      noarch
 
-BuildRequires:  python-devel, pygtk2-devel
+BuildRequires:  gcc, m4, automake, autogen, autoconf
+BuildRequires:  pygtk2-devel
 BuildRequires:  desktop-file-utils, gettext
 Requires:       recordmydesktop >= %{version}
 Requires:       pygtk2
+%if 0%{?fedora} >= 22
+Requires:       python27
+%elif 0%{?centos} >= 8
+Requires:       python27
+%endif
 
 %description
 Graphical frontend for the recordmydesktop desktop session recorder.
 
 recordMyDesktop is a desktop session recorder for linux that attempts to be 
-easy to use, yet also effective at it's primary task.
+easy to use, yet also effective at its primary task.
 
 As such, the program is separated in two parts; a simple command line tool that
 performs the basic tasks of capturing and encoding and an interface that 
@@ -32,6 +36,9 @@ exposes the program functionality in a usable way.
 # Use /var/tmp by default
 sed -i -e 's@"/tmp"@"/var/tmp"@' src/rmdConfig.*
 
+# Clean up interpreter shebang
+sed -i -e 's@^#!/usr/bin/python$@#!/usr/bin/env python2@' src/gtk-recordMyDesktop.in
+
 %build
 %configure
 make %{?_smp_mflags}
@@ -49,11 +56,16 @@ desktop-file-install --delete-original  \
 %files -f gtk-recordMyDesktop.lang
 %doc AUTHORS COPYING README ChangeLog
 %{_bindir}/*
-%{python_sitelib}/*
+%{python2_sitelib}/*
 %{_datadir}/applications/*
 %{_datadir}/pixmaps/*
 
 %changelog
+* Tue Feb 09 2021 James Edington <james@ishygddt.xyz> - 0.3.8-20
+- Fix shebang for https://developers.redhat.com/blog/2018/11/14/python-in-rhel-8/#Why_not_just_Python
+- Update BuildRequires
+- Fix typos and clean up spec file
+
 * Wed Jul 26 2017 Fedora Release Engineering <releng@fedoraproject.org> - 0.3.8-19
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild
 

recordmydesktop.spec

@@ -6,36 +6,41 @@ Summary:        Desktop session recorder with audio and video
 License:        GPLv2+
 URL:            http://recordmydesktop.sourceforge.net/
 Source0:        http://downloads.sourceforge.net/recordmydesktop/%{name}-%{version}.tar.gz
+
 # from gentoo: http://bugs.gentoo.org/attachment.cgi?id=209904
 # 2010-01-15: Bug with proposed fix already upstream:
 # http://sourceforge.net/tracker/?func=detail&aid=2889699&group_id=172357&atid=861428
 Patch0:         recordmydesktop-shmstr.h-to-shmproto.h.patch
+
 # Use default Alsa device instead of hardcoded device:
 # https://bugzilla.redhat.com/show_bug.cgi?id=538853
 Patch1:         recordmydesktop-ALSA-default.patch
+
 # Use sane theora defaults
 # https://bugzilla.redhat.com/show_bug.cgi?id=525155
 Patch2:         recordmydesktop-sane-theora-defaults.patch
+
 # Fix jack support detection
 # https://bugzilla.redhat.com/show_bug.cgi?id=554292
 # Patch by debian
 # 2010-01-15: patch submitted upstream:
 # https://sourceforge.net/tracker/?func=detail&aid=2894861&group_id=172357&atid=861428
 Patch3:         recordmydesktop-fix-configure-ac-jack-support.patch
+
 # Use /var/tmp by default for writing large files
 # See http://fedoraproject.org/wiki/Features/tmp-on-tmpfs
 Patch4:         recordmydesktop-var-tmp.patch
 
 BuildRequires:  libXdamage-devel, libSM-devel
-BuildRequires:  libXext-devel
+BuildRequires:  libXext-devel, libXfixes-devel
 BuildRequires:  alsa-lib-devel, zlib-devel
-BuildRequires:  libtheora-devel, libvorbis-devel, jack-audio-connection-kit-devel
-Requires:       jack-audio-connection-kit-example-clients
-
+BuildRequires:  libogg-devel, libtheora-devel, libvorbis-devel, jack-audio-connection-kit-devel, alsa-lib-devel
+Requires:       jack-audio-connection-kit-example-clients OR alsa-lib
+Requires:       libX11, libXdamage, libXfixes, libICE, libSM
 
 %description
 recordMyDesktop is a desktop session recorder for linux that attempts to be 
-easy to use, yet also effective at it's primary task.
+easy to use, yet also effective at its primary task.
 
 As such, the program is separated in two parts; a simple command line tool that
 performs the basic tasks of capturing and encoding and an interface that 
@@ -69,6 +74,11 @@ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -c -p"
 
 
 %changelog
+* Tue Feb 09 2021 James Edington <james@ishygddt.xyz> - 0.3.8-20
+- Update BuildRequires
+- Update Requires
+- Fix typos and clean up spec file
+
 * Thu Aug 03 2017 Fedora Release Engineering <releng@fedoraproject.org> - 0.3.8.1-19
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild