anon's review #1

New Issue

anon · 2023-11-21T19:05:15-05:00

anon commented

2023-11-21 19:05:15 -05:00

General

please add a .gitignore with these contents:

*.o
xharthe

i tried to create a pull request, but apparently i have no clue how to do it using gitea.
only done it on github before.

actually i know someone who is a beginner. he asks me for advice over chat time to time.
should i show this to him?

readme

Everything related to my libraries is clean of all warning options on Clang, GCC and Valgrind.

only you care. in fact you should be selling this idea of clearity inside xharta.
make it a revalation to arrive to, not a random comment hitting the person on the forehead right away

I'm not a native English speaker nor a real programmer, only a hobbyist, so this “book” will be full of grammatical mistakes, but not compiler warnings. Please be patient, C is a small language, even for the time when it was made, so if you ignore my rambling

screams of autism. terrible marketing.
omit it.

You won't get a job after reading this “book”, only some knowledge.

as above

First of all, read the “README.md” file in base directory.

this line is in the mid of README...
can you see how thats circular?

which you can also download from my GitLain repository.

add a "Mirrors" section
you can list lain there and (if you finish it) i will put it on my gitea too

chapter/*

please remove those gigantic fucking license claims,
either move them to the end or make them single line.
literally no one wants to see them.

chapter0

you start commenting headers before explaining what they are

that girl metaphore made me smile

never put underscore before or after the identifier

void example_function(char * input_i_do_not_want_to_change_in_place) {
	char * input_i_do_not_want_to_change_in_place_ = strdup(input_i_do_not_want_to_change_in_place_);
	// ...
}

its interesting that you consider '"' and ''' operators

string_copy() is perhaps the worst example to string_0 & string_1,
because thats the textbook example of confusion over which
is source and which is dest

this is what i had time today

# General please add a .gitignore with these contents: ``` *.o xharthe ``` i tried to create a pull request, but apparently i have no clue how to do it using gitea. only done it on github before. actually i know someone who is a beginner. he asks me for advice over chat time to time. should i show this to him? # readme > Everything related to my libraries is clean of all warning options on Clang, GCC and Valgrind. only you care. in fact you should be selling this idea of clearity inside xharta. make it a revalation to arrive to, not a random comment hitting the person on the forehead right away > I'm not a native English speaker nor a real programmer, only a hobbyist, so this “book” will be full of grammatical mistakes, but not compiler warnings. Please be patient, C is a small language, even for the time when it was made, so if you ignore my rambling screams of autism. terrible marketing. omit it. > You won't get a job after reading this “book”, only some knowledge. as above > First of all, read the “README.md” file in base directory. this line is in the mid of README... can you see how thats circular? > which you can also download from my GitLain repository. add a "Mirrors" section you can list lain there and (if you finish it) i will put it on my gitea too # chapter/\* please remove those gigantic fucking license claims, either move them to the end or make them single line. literally no one wants to see them. # chapter0 you start commenting headers before explaining what they are that girl metaphore made me smile > never put underscore before or after the identifier ```C void example_function(char * input_i_do_not_want_to_change_in_place) { char * input_i_do_not_want_to_change_in_place_ = strdup(input_i_do_not_want_to_change_in_place_); // ... } ``` its interesting that you consider '\"' and '\'' operators string_copy() is perhaps the worst example to string_0 & string_1, because thats the textbook example of confusion over which is source and which is dest --- this is what i had time today

xolatile commented

2023-12-03 05:30:23 -05:00

Changed:

Added '.gitignore' file with that content, it'll change over time.
Feel free to show this to anyone, even tho it's still work in progress.
Removed license claims from all C files, you're right...
Renamed string and memory functions to use 'destination' and 'source'.
Not changed:
Uh, autism in comments might be removed in the future, not now... L:
Comments are placed somewhat coherently, as much as I can mentally handle.

Thanks for the input 8697, output is now better I hope...

Changed: - Added '.gitignore' file with that content, it'll change over time. - Feel free to show this to anyone, even tho it's still work in progress. - Removed license claims from all C files, you're right... - Renamed string and memory functions to use 'destination' and 'source'. Not changed: - Uh, autism in comments might be removed in the future, not now... L: - Comments are placed somewhat coherently, as much as I can mentally handle. Thanks for the input 8697, output is now better I hope...

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xolatile/xhartae#1